support multiday for local provider; make each day's data midnight to midnight, so it's consistent with all other providers; make indentations consistent#1
Merged
Conversation
- Fix solarRadiation NaN bug: undefined * 24 / 1000 produced NaN - Fix precip NaN bug: undefined - lastRainCount produced NaN - Fix falsy check for temp=0: 0 || undefined incorrectly returned undefined - Make solar and wind sensors optional in validation - Update Observation interface to allow undefined values Many PWS don't have solar radiation or wind sensors, so the validation now only requires temp, humidity, and precip as mandatory fields. https://claude.ai/code/session_01AyytHmyNaRfEtfMw5RUod8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.