Fix media and content type #509
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordonPhillips
force-pushed
the
fix-media-and-content-type
branch
from
1c44b80 to
963ed7d
Compare
nateprewitt
reviewed
Jun 17, 2025
Comment on lines
+196
to
+200
| def _compute_content_length(self, payload: Any) -> int | None: | ||
| content_length = self._seek(payload, 0, 2) | ||
| if content_length is not None: | ||
| self._seek(payload, 0, 0) | ||
| return content_length |
There was a problem hiding this comment.
I think this is a vector for data corruption right? If you get a partially read stream, we can't seek back to beginning. We'd want to use tell to check our current position before reading to the end or take the length and seek in reverse from the end. I think that's potentially going to have issues with length of bytes vs characters though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates media type serialization to pick up all the proper cases, including omitting media type if there's no body. It also introduces content-length serialization.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.