Resolve signing issues from mismatched list header formatting #586
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Overview
This PR fixes
InvalidSignatureExceptionerrors caused by inconsistent formatting of list-valued headers during request signing. Previously, headers like were sent asvalue1,value2but signed asvalue1, value2, leading to signature mismatches. The SDK now ensures both the request and signature use identical header formatting.Note
This is a bit weird since the CRT will handle multi-valued headers by adding them individually on the request. The server seems to be handling this by joining them by the
,for signature verification.Testing
Tested this change using the script below with both the
AWSCRTHTTPClientandAIOHTTPClientclients:Without this PR I was receiving the following error:
With this change I received successful responses.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.