Skip to content

test: run tests with vitest, fix test type errors #1602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented May 22, 2025

  • fixes retry script for tests
  • fixes type errors in tests due to upgrading to ts5.8 and its new eslint standards (in a quick way, mostly with any)
  • updates integration test model with new ruleset

@kuhe kuhe requested a review from a team as a code owner May 22, 2025 14:54
@kuhe kuhe changed the title chore: fix command retry script test: run tests with vitest, fix test type errors May 22, 2025
@@ -7,8 +7,8 @@
"scripts": {
"clean": "turbo run clean --force --parallel",
"build": "turbo run build",
"test": "turbo run test",
"test:integration": "yarn build-test-packages && turbo run test:integration",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as with jsv3, turbo is a slow way to run tests because it spins up separate vite processes.

A singular vitest process with a view of all tests is much faster for test compilation.

@kuhe kuhe merged commit e5bb1e2 into smithy-lang:main May 22, 2025
10 checks passed
@kuhe kuhe deleted the chore/build branch May 22, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants