Add protocol tests for awsQueryCompatible #2672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JordonPhillips
force-pushed
the
query-compat-protocol-tests
branch
from
3a9bb81 to
c37b8eb
Compare
mullermp
approved these changes
Jun 20, 2025
smithy-aws-protocol-tests/model/awsJson1_0/query-compatible.smithy
Outdated
Show resolved
Hide resolved
JordonPhillips
force-pushed
the
query-compat-protocol-tests
branch
from
c37b8eb to
2eb6a28
Compare
sugmanue
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds protocol tests for the awsQueryCompatible trait for both
rpcv2CborandawsJson1_0.These tests may be successfully run by existing protocol test implementations, but changes must be made to get the full effect. Protocol test implementations must be updated to support the
ErrorCodeParamsvendor params if they generically expose error code or query error type.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.