Introduce the aux data field to Symbolic Value #130
iamrecursionci.yml
on: pull_request
Lint
42s
Check Formatting
20s
Matrix: Test
Annotations
1 error and 80 warnings
|
Check Formatting
The process '/home/runner/.cargo/bin/cargo' failed with exit code 1
|
|
Check Formatting
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Check Formatting
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Check Formatting
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Check Formatting
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Check Formatting
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
struct constructor field order is inconsistent with struct definition field order:
src/vm/value/mod.rs#L234
warning: struct constructor field order is inconsistent with struct definition field order
--> src/vm/value/mod.rs:234:18
|
234 | Box::new(Self {
| __________________^
235 | | instruction_pointer,
236 | | data,
237 | | provenance,
238 | | aux_data,
239 | | })
| |_________^ help: try: `Self { instruction_pointer, provenance, data, aux_data }`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_struct_constructor
= note: `#[warn(clippy::inconsistent_struct_constructor)]` implied by `#[warn(clippy::pedantic)]`
|
|
this method could have a `#[must_use]` attribute:
src/vm/value/mod.rs#L228
warning: this method could have a `#[must_use]` attribute
--> src/vm/value/mod.rs:228:5
|
228 | / pub fn new(
229 | | instruction_pointer: u32,
230 | | data: TCSVD,
231 | | provenance: Provenance,
232 | | aux_data: TCAuxData,
233 | | ) -> Box<Self> {
| |__________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate
help: add the attribute
|
228 ~ #[must_use] pub fn new(
229 + instruction_pointer: u32,
230 + data: TCSVD,
231 + provenance: Provenance,
232 + aux_data: TCAuxData,
233 ~ ) -> Box<Self> {
|
|
|
this expression borrows a value the compiler would automatically borrow:
src/utility.rs#L9
warning: this expression borrows a value the compiler would automatically borrow
--> src/utility.rs:9:5
|
9 | (&string[0..8]).to_string()
| ^^^^^^^^^^^^^^^ help: change this to: `string[0..8]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this function could have a `#[must_use]` attribute:
src/utility.rs#L7
warning: this function could have a `#[must_use]` attribute
--> src/utility.rs:7:1
|
7 | pub fn clip_uuid(uuid: &Uuid) -> String {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add the attribute: `#[must_use] pub fn clip_uuid(uuid: &Uuid) -> String`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate
= note: `#[warn(clippy::must_use_candidate)]` implied by `#[warn(clippy::pedantic)]`
|
|
docs for function returning `Result` missing `# Errors` section:
src/inference/mod.rs#L207
warning: docs for function returning `Result` missing `# Errors` section
--> src/inference/mod.rs:207:5
|
207 | pub fn hoist_structs(&mut self) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
= note: `#[warn(clippy::missing_errors_doc)]` implied by `#[warn(clippy::pedantic)]`
|
|
used `cloned` where `copied` could be used instead:
src/inference/state.rs#L609
warning: used `cloned` where `copied` could be used instead
--> src/inference/state.rs:609:32
|
609 | self.inferences.keys().cloned().collect()
| ^^^^^^ help: try: `copied`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cloned_instead_of_copied
= note: `#[warn(clippy::cloned_instead_of_copied)]` implied by `#[warn(clippy::pedantic)]`
|
|
this function has too many lines (259/100):
src/inference/state.rs#L97
warning: this function has too many lines (259/100)
--> src/inference/state.rs:97:5
|
97 | / fn register_internal(&mut self, value: RuntimeBoxedVal) -> TCBoxedVal {
98 | | // Storage slots need specialised handling
99 | | // TODO this could be a return value from this method to avoid quadratic
100 | | // traversal
... |
366 | | new_value
367 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_lines
= note: `#[warn(clippy::too_many_lines)]` implied by `#[warn(clippy::pedantic)]`
|
|
boxed return of the sized type `vm::value::SymbolicValue<inference::state::TypeVariable>`:
src/inference/state.rs#L97
warning: boxed return of the sized type `vm::value::SymbolicValue<inference::state::TypeVariable>`
--> src/inference/state.rs:97:64
|
97 | fn register_internal(&mut self, value: RuntimeBoxedVal) -> TCBoxedVal {
| ^^^^^^^^^^ help: try: `vm::value::SymbolicValue<inference::state::TypeVariable>`
|
= help: changing this also requires a change to the return expressions in this function
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_box_returns
= note: `#[warn(clippy::unnecessary_box_returns)]` implied by `#[warn(clippy::pedantic)]`
|
|
this match arm has an identical body to another arm:
src/inference/state.rs#L88
warning: this match arm has an identical body to another arm
--> src/inference/state.rs:88:13
|
88 | RSVD::Value { .. } => true,
| ------------------^^^^^^^^
| |
| help: try merging the arm patterns: `RSVD::Value { .. } | RSVD::CallData { .. }`
|
= help: or try changing either arm body
note: other arm here
--> src/inference/state.rs:89:13
|
89 | RSVD::CallData { .. } => true,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms
|
|
this match arm has an identical body to another arm:
src/inference/state.rs#L89
warning: this match arm has an identical body to another arm
--> src/inference/state.rs:89:13
|
89 | RSVD::CallData { .. } => true,
| ---------------------^^^^^^^^
| |
| help: try merging the arm patterns: `RSVD::CallData { .. } | RSVD::StorageSlot { .. }`
|
= help: or try changing either arm body
note: other arm here
--> src/inference/state.rs:87:13
|
87 | RSVD::StorageSlot { .. } => true,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms
|
|
this match arm has an identical body to another arm:
src/inference/state.rs#L88
warning: this match arm has an identical body to another arm
--> src/inference/state.rs:88:13
|
88 | RSVD::Value { .. } => true,
| ------------------^^^^^^^^
| |
| help: try merging the arm patterns: `RSVD::Value { .. } | RSVD::StorageSlot { .. }`
|
= help: or try changing either arm body
note: other arm here
--> src/inference/state.rs:87:13
|
87 | RSVD::StorageSlot { .. } => true,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/inference/lift/sub_word.rs#L148
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/inference/lift/sub_word.rs:148:58
|
148 | let (value, shift) = SubWordValue::get_shift(&value);
| ^^^^^^ help: change this to: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/inference/lift/sub_word.rs#L120
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/inference/lift/sub_word.rs:120:19
|
120 | _ => (&value, 0),
| ^^^^^^ help: change this to: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/inference/lift/sub_word.rs#L118
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/inference/lift/sub_word.rs:118:23
|
118 | _ => (&value, 0),
| ^^^^^^ help: change this to: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/inference/lift/sub_word.rs#L115
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/inference/lift/sub_word.rs:115:31
|
115 | _ => (&value, 0),
| ^^^^^^ help: change this to: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/inference/lift/sub_word.rs#L113
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/inference/lift/sub_word.rs:113:30
|
113 | ... (÷nd, shift.into())
| ^^^^^^^^^ help: change this to: `dividend`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/inference/lift/sub_word.rs#L105
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/inference/lift/sub_word.rs:105:27
|
105 | _ => (&value, 0),
| ^^^^^^ help: change this to: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/inference/lift/sub_word.rs#L102
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/inference/lift/sub_word.rs:102:30
|
102 | ... (&value, 0)
| ^^^^^^ help: change this to: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/inference/lift/sub_word.rs#L100
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/inference/lift/sub_word.rs:100:30
|
100 | ... (÷nd, usize::from(exp))
| ^^^^^^^^^ help: change this to: `dividend`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/inference/lift/sub_word.rs#L91
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/inference/lift/sub_word.rs:91:23
|
91 | _ => (&value, 0),
| ^^^^^^ help: change this to: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/inference/lift/sub_word.rs#L90
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/inference/lift/sub_word.rs:90:54
|
90 | RSVD::KnownData { value: shift } => (&value, shift.into()),
| ^^^^^^ help: change this to: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
unneeded `return` statement:
src/inference/lift/packed_encoding.rs#L58
warning: unneeded `return` statement
--> src/inference/lift/packed_encoding.rs:58:13
|
58 | return left_ors;
| ^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` implied by `#[warn(clippy::all)]`
= help: remove `return`
|
|
consider adding a `;` to the last statement for consistent formatting:
src/inference/expression.rs#L251
warning: consider adding a `;` to the last statement for consistent formatting
--> src/inference/expression.rs:251:25
|
251 | write!(f, ", ")?
| ^^^^^^^^^^^^^^^^ help: add a `;` here: `write!(f, ", ")?;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/inference/debug.rs#L77
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/inference/debug.rs:77:35
|
77 | if !seen.contains(&element) {
| ^^^^^^^^ help: change this to: `element`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/inference/debug.rs#L72
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/inference/debug.rs:72:35
|
72 | if !seen.contains(&value) {
| ^^^^^^ help: change this to: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/inference/debug.rs#L69
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/inference/debug.rs:69:35
|
69 | if !seen.contains(&key) {
| ^^^^ help: change this to: `key`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/inference/debug.rs#L64
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/inference/debug.rs:64:35
|
64 | if !seen.contains(&element) {
| ^^^^^^^^ help: change this to: `element`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/inference/debug.rs#L59
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/inference/debug.rs:59:35
|
59 | if !seen.contains(&id) {
| ^^^ help: change this to: `id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
note: the lint level is defined here
--> src/lib.rs:112:9
|
112 | #![warn(clippy::all, clippy::cargo, clippy::pedantic)]
| ^^^^^^^^^^^
= note: `#[warn(clippy::needless_borrow)]` implied by `#[warn(clippy::all)]`
|
|
this match arm has an identical body to another arm:
src/inference/debug.rs#L63
warning: this match arm has an identical body to another arm
--> src/inference/debug.rs:63:13
|
63 | TE::FixedArray { element, .. } => {
| ^-----------------------------
| |
| _____________help: try merging the arm patterns: `TE::FixedArray { element, .. } | TE::DynamicArray { element }`
| |
64 | | if !seen.contains(&element) {
65 | | print_tv_impl(*element, state, next_indent_level, seen);
66 | | }
67 | | }
| |_____________^
|
= help: or try changing either arm body
note: other arm here
--> src/inference/debug.rs:76:13
|
76 | / TE::DynamicArray { element } => {
77 | | if !seen.contains(&element) {
78 | | print_tv_impl(*element, state, next_indent_level, seen);
79 | | }
80 | | }
| |_____________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms
= note: `#[warn(clippy::match_same_arms)]` implied by `#[warn(clippy::pedantic)]`
|
|
consider adding a `;` to the last statement for consistent formatting:
src/inference/debug.rs#L34
warning: consider adding a `;` to the last statement for consistent formatting
--> src/inference/debug.rs:34:5
|
34 | print_tv_impl(ty, state, 0, &mut HashSet::new())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `print_tv_impl(ty, state, 0, &mut HashSet::new());`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
note: the lint level is defined here
--> src/lib.rs:112:37
|
112 | #![warn(clippy::all, clippy::cargo, clippy::pedantic)]
| ^^^^^^^^^^^^^^^^
= note: `#[warn(clippy::semicolon_if_nothing_returned)]` implied by `#[warn(clippy::pedantic)]`
|
|
struct constructor field order is inconsistent with struct definition field order:
src/vm/value/mod.rs#L234
warning: struct constructor field order is inconsistent with struct definition field order
--> src/vm/value/mod.rs:234:18
|
234 | Box::new(Self {
| __________________^
235 | | instruction_pointer,
236 | | data,
237 | | provenance,
238 | | aux_data,
239 | | })
| |_________^ help: try: `Self { instruction_pointer, provenance, data, aux_data }`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_struct_constructor
= note: `#[warn(clippy::inconsistent_struct_constructor)]` implied by `#[warn(clippy::pedantic)]`
|
|
this method could have a `#[must_use]` attribute:
src/vm/value/mod.rs#L228
warning: this method could have a `#[must_use]` attribute
--> src/vm/value/mod.rs:228:5
|
228 | / pub fn new(
229 | | instruction_pointer: u32,
230 | | data: TCSVD,
231 | | provenance: Provenance,
232 | | aux_data: TCAuxData,
233 | | ) -> Box<Self> {
| |__________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate
help: add the attribute
|
228 ~ #[must_use] pub fn new(
229 + instruction_pointer: u32,
230 + data: TCSVD,
231 + provenance: Provenance,
232 + aux_data: TCAuxData,
233 ~ ) -> Box<Self> {
|
|
|
this expression borrows a value the compiler would automatically borrow:
src/utility.rs#L9
warning: this expression borrows a value the compiler would automatically borrow
--> src/utility.rs:9:5
|
9 | (&string[0..8]).to_string()
| ^^^^^^^^^^^^^^^ help: change this to: `string[0..8]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this function could have a `#[must_use]` attribute:
src/utility.rs#L7
warning: this function could have a `#[must_use]` attribute
--> src/utility.rs:7:1
|
7 | pub fn clip_uuid(uuid: &Uuid) -> String {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add the attribute: `#[must_use] pub fn clip_uuid(uuid: &Uuid) -> String`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#must_use_candidate
= note: `#[warn(clippy::must_use_candidate)]` implied by `#[warn(clippy::pedantic)]`
|
|
docs for function returning `Result` missing `# Errors` section:
src/inference/mod.rs#L207
warning: docs for function returning `Result` missing `# Errors` section
--> src/inference/mod.rs:207:5
|
207 | pub fn hoist_structs(&mut self) -> Result<()> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_errors_doc
= note: `#[warn(clippy::missing_errors_doc)]` implied by `#[warn(clippy::pedantic)]`
|
|
used `cloned` where `copied` could be used instead:
src/inference/state.rs#L609
warning: used `cloned` where `copied` could be used instead
--> src/inference/state.rs:609:32
|
609 | self.inferences.keys().cloned().collect()
| ^^^^^^ help: try: `copied`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cloned_instead_of_copied
= note: `#[warn(clippy::cloned_instead_of_copied)]` implied by `#[warn(clippy::pedantic)]`
|
|
this function has too many lines (259/100):
src/inference/state.rs#L97
warning: this function has too many lines (259/100)
--> src/inference/state.rs:97:5
|
97 | / fn register_internal(&mut self, value: RuntimeBoxedVal) -> TCBoxedVal {
98 | | // Storage slots need specialised handling
99 | | // TODO this could be a return value from this method to avoid quadratic
100 | | // traversal
... |
366 | | new_value
367 | | }
| |_____^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_lines
= note: `#[warn(clippy::too_many_lines)]` implied by `#[warn(clippy::pedantic)]`
|
|
boxed return of the sized type `vm::value::SymbolicValue<inference::state::TypeVariable>`:
src/inference/state.rs#L97
warning: boxed return of the sized type `vm::value::SymbolicValue<inference::state::TypeVariable>`
--> src/inference/state.rs:97:64
|
97 | fn register_internal(&mut self, value: RuntimeBoxedVal) -> TCBoxedVal {
| ^^^^^^^^^^ help: try: `vm::value::SymbolicValue<inference::state::TypeVariable>`
|
= help: changing this also requires a change to the return expressions in this function
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_box_returns
= note: `#[warn(clippy::unnecessary_box_returns)]` implied by `#[warn(clippy::pedantic)]`
|
|
this match arm has an identical body to another arm:
src/inference/state.rs#L88
warning: this match arm has an identical body to another arm
--> src/inference/state.rs:88:13
|
88 | RSVD::Value { .. } => true,
| ------------------^^^^^^^^
| |
| help: try merging the arm patterns: `RSVD::Value { .. } | RSVD::CallData { .. }`
|
= help: or try changing either arm body
note: other arm here
--> src/inference/state.rs:89:13
|
89 | RSVD::CallData { .. } => true,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms
|
|
this match arm has an identical body to another arm:
src/inference/state.rs#L89
warning: this match arm has an identical body to another arm
--> src/inference/state.rs:89:13
|
89 | RSVD::CallData { .. } => true,
| ---------------------^^^^^^^^
| |
| help: try merging the arm patterns: `RSVD::CallData { .. } | RSVD::StorageSlot { .. }`
|
= help: or try changing either arm body
note: other arm here
--> src/inference/state.rs:87:13
|
87 | RSVD::StorageSlot { .. } => true,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms
|
|
this match arm has an identical body to another arm:
src/inference/state.rs#L88
warning: this match arm has an identical body to another arm
--> src/inference/state.rs:88:13
|
88 | RSVD::Value { .. } => true,
| ------------------^^^^^^^^
| |
| help: try merging the arm patterns: `RSVD::Value { .. } | RSVD::StorageSlot { .. }`
|
= help: or try changing either arm body
note: other arm here
--> src/inference/state.rs:87:13
|
87 | RSVD::StorageSlot { .. } => true,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/inference/lift/sub_word.rs#L148
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/inference/lift/sub_word.rs:148:58
|
148 | let (value, shift) = SubWordValue::get_shift(&value);
| ^^^^^^ help: change this to: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/inference/lift/sub_word.rs#L120
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/inference/lift/sub_word.rs:120:19
|
120 | _ => (&value, 0),
| ^^^^^^ help: change this to: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/inference/lift/sub_word.rs#L118
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/inference/lift/sub_word.rs:118:23
|
118 | _ => (&value, 0),
| ^^^^^^ help: change this to: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/inference/lift/sub_word.rs#L115
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/inference/lift/sub_word.rs:115:31
|
115 | _ => (&value, 0),
| ^^^^^^ help: change this to: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/inference/lift/sub_word.rs#L113
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/inference/lift/sub_word.rs:113:30
|
113 | ... (÷nd, shift.into())
| ^^^^^^^^^ help: change this to: `dividend`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/inference/lift/sub_word.rs#L105
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/inference/lift/sub_word.rs:105:27
|
105 | _ => (&value, 0),
| ^^^^^^ help: change this to: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/inference/lift/sub_word.rs#L102
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/inference/lift/sub_word.rs:102:30
|
102 | ... (&value, 0)
| ^^^^^^ help: change this to: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/inference/lift/sub_word.rs#L100
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/inference/lift/sub_word.rs:100:30
|
100 | ... (÷nd, usize::from(exp))
| ^^^^^^^^^ help: change this to: `dividend`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/inference/lift/sub_word.rs#L91
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/inference/lift/sub_word.rs:91:23
|
91 | _ => (&value, 0),
| ^^^^^^ help: change this to: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/inference/lift/sub_word.rs#L90
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/inference/lift/sub_word.rs:90:54
|
90 | RSVD::KnownData { value: shift } => (&value, shift.into()),
| ^^^^^^ help: change this to: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
unneeded `return` statement:
src/inference/lift/packed_encoding.rs#L58
warning: unneeded `return` statement
--> src/inference/lift/packed_encoding.rs:58:13
|
58 | return left_ors;
| ^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `#[warn(clippy::needless_return)]` implied by `#[warn(clippy::all)]`
= help: remove `return`
|
|
consider adding a `;` to the last statement for consistent formatting:
src/inference/expression.rs#L251
warning: consider adding a `;` to the last statement for consistent formatting
--> src/inference/expression.rs:251:25
|
251 | write!(f, ", ")?
| ^^^^^^^^^^^^^^^^ help: add a `;` here: `write!(f, ", ")?;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/inference/debug.rs#L77
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/inference/debug.rs:77:35
|
77 | if !seen.contains(&element) {
| ^^^^^^^^ help: change this to: `element`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/inference/debug.rs#L72
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/inference/debug.rs:72:35
|
72 | if !seen.contains(&value) {
| ^^^^^^ help: change this to: `value`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/inference/debug.rs#L69
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/inference/debug.rs:69:35
|
69 | if !seen.contains(&key) {
| ^^^^ help: change this to: `key`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/inference/debug.rs#L64
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/inference/debug.rs:64:35
|
64 | if !seen.contains(&element) {
| ^^^^^^^^ help: change this to: `element`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
|
|
this expression creates a reference which is immediately dereferenced by the compiler:
src/inference/debug.rs#L59
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> src/inference/debug.rs:59:35
|
59 | if !seen.contains(&id) {
| ^^^ help: change this to: `id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
note: the lint level is defined here
--> src/lib.rs:112:9
|
112 | #![warn(clippy::all, clippy::cargo, clippy::pedantic)]
| ^^^^^^^^^^^
= note: `#[warn(clippy::needless_borrow)]` implied by `#[warn(clippy::all)]`
|
|
this match arm has an identical body to another arm:
src/inference/debug.rs#L63
warning: this match arm has an identical body to another arm
--> src/inference/debug.rs:63:13
|
63 | TE::FixedArray { element, .. } => {
| ^-----------------------------
| |
| _____________help: try merging the arm patterns: `TE::FixedArray { element, .. } | TE::DynamicArray { element }`
| |
64 | | if !seen.contains(&element) {
65 | | print_tv_impl(*element, state, next_indent_level, seen);
66 | | }
67 | | }
| |_____________^
|
= help: or try changing either arm body
note: other arm here
--> src/inference/debug.rs:76:13
|
76 | / TE::DynamicArray { element } => {
77 | | if !seen.contains(&element) {
78 | | print_tv_impl(*element, state, next_indent_level, seen);
79 | | }
80 | | }
| |_____________^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms
= note: `#[warn(clippy::match_same_arms)]` implied by `#[warn(clippy::pedantic)]`
|
|
consider adding a `;` to the last statement for consistent formatting:
src/inference/debug.rs#L34
warning: consider adding a `;` to the last statement for consistent formatting
--> src/inference/debug.rs:34:5
|
34 | print_tv_impl(ty, state, 0, &mut HashSet::new())
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `print_tv_impl(ty, state, 0, &mut HashSet::new());`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#semicolon_if_nothing_returned
note: the lint level is defined here
--> src/lib.rs:112:37
|
112 | #![warn(clippy::all, clippy::cargo, clippy::pedantic)]
| ^^^^^^^^^^^^^^^^
= note: `#[warn(clippy::semicolon_if_nothing_returned)]` implied by `#[warn(clippy::pedantic)]`
|
|
Lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Lint
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test (ubuntu-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Test (ubuntu-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test (ubuntu-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test (ubuntu-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test (ubuntu-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test (macos-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Test (macos-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test (macos-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test (macos-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
Test (macos-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|