Implement discovery of packed encodings #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamrecursion
force-pushed
the
wip/ara/discover-packed-encodings
branch
2 times, most recently
from
f573167
to
c08600f
Compare
kustosz
approved these changes
Aug 2, 2023
iamrecursion
force-pushed
the
wip/ara/discover-packed-encodings
branch
3 times, most recently
from
8a121ef
to
ca1970b
Compare
This commit implements the following features into the analyzer: - Discovery and lifting of multiplicative shifts of values that are commonly used by solc when constructing packed encodings. - Discovery and lifting of packed encoding structures themselves, taking the form of bitwise disjunctions of masked and shifted values. - Care is taken in the lifting pass to ensure that segments of packed encodings that are _not used_ (are direct reads from the slot into which the packed encoding is being written) are ignored, thus ensuring we do not infer types for segments of storage slots that are not really written to. - Loads from storage are now wrapped in `SLoad` nodes, allowing for detailed tracking of when a value was loaded from storage in the value trees.
iamrecursion
force-pushed
the
wip/ara/discover-packed-encodings
branch
from
ca1970b
to
f7672dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit implements the following features into the analyzer:
SLoadnodes, allowing for detailed tracking of when a value was loaded from storage in the value trees.Details
Please carefully check my logic in all of these changes as they can be quite subtle.
Checklist