Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add next_audit_date to the AssetsController logic #16471

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ManuelW77
Copy link

Fixed #16459 Audit date is not saved when creating an asset

Copy link

what-the-diff bot commented Mar 10, 2025

PR Summary

  • Enhanced Asset Updating Feature
    The updating process for 'Assets' has been improved. The date for the next audit of an asset can now be submitted and stored directly through the request. This feature will streamline the process and add convenience.

@snipe
Copy link
Owner

snipe commented Mar 11, 2025

If the next audit date is not manually filled, it needs to be overridden by the audit rules in the notification settings. The line right below the line you added checks to see if $settings->audit_interval is empty, and if it isn't, it calculates what the next audit date will be - which means if you are trying to override the next audit date manually on the store(), the if/else right after will overwrite your intended changes.

@ManuelW77
Copy link
Author

If the next audit date is not manually filled, it needs to be overridden by the audit rules in the notification settings. The line right below the line you added checks to see if $settings->audit_interval is empty, and if it isn't, it calculates what the next audit date will be - which means if you are trying to override the next audit date manually on the store(), the if/else right after will overwrite your intended changes.

I have different audit intervals for different devices. So as example i don't use the default interval and set the date manually. But it was not saved on creation.

@snipe
Copy link
Owner

snipe commented Mar 12, 2025

I have different audit intervals for different devices. So as example i don't use the default interval and set the date manually. But it was not saved on creation.

That's fine, but other people do, so the order is still incorrect. If I set a specific override while generally using the interval, the audit interval math below it will overwrite that override.

Changed for respecting the audit intervall
@ManuelW77
Copy link
Author

Ah, i understand what you mean. Ok, so i changed ti for respecting a filled audit interval field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants