Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #16217: added skip_ssl on database dump config #16513

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ntaylor-86
Copy link

@ntaylor-86 ntaylor-86 commented Mar 17, 2025

fixes #16217

Recently ran into the same issue is as #16217

image

Looked up the docs for spatie/laravel-backup https://github.com/spatie/laravel-backup

And found there was a skip_ssl value that could be set in the config/database.php - https://github.com/spatie/laravel-backup/blob/dd810a2edae269392b93149d622930c5f916f599/docs/installation-and-setup.md?plain=1#L417

Manually tested setting the skip_ssl value to true in my docker containers config file, then I was able to successfully Generate a Backup manually from the UI.

Copy link

welcome bot commented Mar 17, 2025

💖 Thanks for this pull request! 💖

We use semantic commit messages to streamline the release process and easily generate changelogs between versions. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix if it doesn't have one already.

Examples of commit messages with semantic prefixes:

  • Fixed #<issue number>: don't overwrite prevent_default if default wasn't prevented
  • Added #<issue number>: add checkout functionality to assets
  • Improved Asset Checkout: use new notification method for checkout

Things that will help get your PR across the finish line:

  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

Copy link

what-the-diff bot commented Mar 17, 2025

PR Summary

  • Introduction of a New Environment Variable for Database Operations
    The team introduced a new environment variable, namely DB_DUMP_SKIP_SSL in the .env.docker file. This allows us to bypass any SSL-related challenges when dumping the database, providing us with a convenient escape route during tricky situations.

  • Incorporation of the New Option in Database Configuration
    The config/database.php file is now updated to include the new 'skip_ssl' option within the database dump configuration. The best part is that if not specified, it defaults to false, i.e., it does not interfere with standard operations.

These changes improve our flexibility when dealing with database manipulations, enabling the system to operate smoothly even in unfavorable conditions related to SSL.

@ntaylor-86 ntaylor-86 changed the title skip_ssl on database dump config Fixed #16217: skip_ssl on database dump config Mar 17, 2025
@ntaylor-86 ntaylor-86 changed the title Fixed #16217: skip_ssl on database dump config Fixed #16217: added skip_ssl on database dump config Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manual Backup in 7.1.16
1 participant