SNOW-2912540: mock-patch try_add_log_to_batch instead of reading _log_batch by sfc-gh-fpawlowski · Pull Request #4321 · snowflakedb/snowpark-python

sfc-gh-fpawlowski · 2026-08-20T16:29:57Z

Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

Fixes SNOW-NNNNNNN
Fill out the following pre-review checklist:
- I am adding a new automated test(s) to verify correctness of my new code
  - If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
- I am adding new logging messages
- I am adding a new telemetry message
- I am adding new credentials
- I am adding a new dependency
- If this is a new feature/behavior, I'm adding the Local Testing parity changes.
- I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
- If adding any arguments to public Snowpark APIs or creating new public Snowpark APIs, I acknowledge that I have ensured my changes include AST support. Follow the link for more information: AST Support Guidelines
Please describe how your code solves the related issue.

Please write a short description of how your code change solves the related issue.

sfc-gh-fpawlowski · 2026-08-20T16:30:17Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

SNOW-2912540: mock-patch try_add_log_to_batch instead of reading _log_batch #4321 : 2 dependent PRs (#4322 , #4326 ) 👈 (View in Graphite)
SNOW-2912540: use IS_V5_DRIVER for cursor request_id access #4314 : 1 other dependent PR (#4317 )
SNOW-2912540: add IS_V5_DRIVER constant; use it for SecretDetector/TelemetryData/TelemetryClient/ReauthenticationRequest imports and pandas/pyarrow/numpy resolution #4313
SNOW-2912540: decouple LocalTestOOBTelemetryService from connector.telemetry_oob #4309 : 1 other dependent PR (#4310 )
SNOW-2912540: inline _create_temp_stage and _create_temp_file_format into analyzer_utils #4308
SNOW-2912540: define ASYNC_RETRY_PATTERN and compat.OK locally #4282
SNOW-2912540: translate create_temp_table=True to table_type in AST encoding (rebased onto main) #4307
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

snowflake-security-bot

Snowflake Security Review

Security grade: A — Passed ✅

This PR was classified as LOW risk by the automated pre-screen.

snowflake-security-bot

Snowflake Security Review

Security grade: A — Passed ✅

This PR was classified as LOW risk by the automated pre-screen.

snowflake-security-bot

Snowflake Security Review

Security grade: A — Passed ✅

This PR was classified as LOW risk by the automated pre-screen.

snowflake-security-bot

Snowflake Security Review

Security grade: A — Passed ✅

This PR was classified as LOW risk by the automated pre-screen.

codecov-commenter · 2026-08-20T18:34:32Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.44%. Comparing base (939ff2a) to head (2257b69).

Additional details and impacted files

@@                       Coverage Diff                       @@
##           SNOW-2912540-request-id-compat    #4321   +/-   ##
===============================================================
  Coverage                           95.44%   95.44%           
===============================================================
  Files                                 172      172           
  Lines                               44771    44771           
  Branches                             7682     7682           
===============================================================
  Hits                                42730    42730           
  Misses                               1264     1264           
  Partials                              777      777

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

snowflake-security-bot

Snowflake Security Review

Security grade: A — Passed ✅

This PR was classified as LOW risk by the automated pre-screen.

snowflake-security-bot

Snowflake Security Review

Security grade: A — Passed ✅

This PR was classified as LOW risk by the automated pre-screen.

snowflake-security-bot

Snowflake Security Review

Security grade: A — Passed ✅

This PR was classified as LOW risk by the automated pre-screen.

snowflake-security-bot

Snowflake Security Review

Security grade: A — Passed ✅

This PR was classified as LOW risk by the automated pre-screen.

snowflake-security-bot

Snowflake Security Review

Security grade: A — Passed ✅

This PR was classified as LOW risk by the automated pre-screen.

…_batch The Universal Driver (drivers#1104, BD#58) moves TelemetryClient's batch buffer into the Rust core, so `_log_batch` no longer exists on Python and conn._telemetry._log_batch raises AttributeError there. Replace the two direct reads of that buffer with a spy on try_add_log_to_batch (the one call Snowpark actually makes), matching the pattern already dominant in modin/test_telemetry.py's other tests. Works unchanged under both drivers since try_add_log_to_batch exists on both.

snowflake-security-bot

Snowflake Security Review

Security grade: A — Passed ✅

This PR was classified as LOW risk by the automated pre-screen.

snowflake-security-bot

Snowflake Security Review

Security grade: A — Passed ✅

This PR was classified as LOW risk by the automated pre-screen.

This was referenced Aug 20, 2026

SNOW-2912540: add IS_V5_DRIVER constant; use it for SecretDetector/TelemetryData/TelemetryClient/ReauthenticationRequest imports and pandas/pyarrow/numpy resolution #4313

Open

SNOW-2912540: use IS_V5_DRIVER for cursor request_id access #4314

Open

This was referenced Aug 20, 2026

SNOW-2912540: remove _pandas_importer(), dedup mock/_options.py numpy handling #4317

Closed

SNOW-2912540: add mitmproxy capture fixture base #4322

Draft

SNOW-2912540: rewrite telemetry tests to verify the actual wire payload #4323

Draft

sfc-gh-fpawlowski marked this pull request as ready for review August 20, 2026 17:08

sfc-gh-fpawlowski requested a review from a team as a code owner August 20, 2026 17:08

sfc-gh-fpawlowski requested review from sfc-gh-bkogan, sfc-gh-jzeng and sfc-gh-yixie and removed request for a team August 20, 2026 17:08

snowflake-security-bot Bot reviewed Aug 20, 2026

View reviewed changes

sfc-gh-fpawlowski changed the base branch from SNOW-2912540-request-id-compat to graphite-base/4321 August 20, 2026 17:14

sfc-gh-fpawlowski force-pushed the graphite-base/4321 branch from 3417aaf to c8a6bc2 Compare August 20, 2026 17:14

sfc-gh-fpawlowski force-pushed the SNOW-2912540-log-batch-mock-patch branch from a450af0 to dc6bd66 Compare August 20, 2026 17:14

sfc-gh-fpawlowski changed the base branch from graphite-base/4321 to SNOW-2912540-request-id-compat August 20, 2026 17:14

snowflake-security-bot Bot reviewed Aug 20, 2026

View reviewed changes

sfc-gh-fpawlowski changed the base branch from SNOW-2912540-request-id-compat to graphite-base/4321 August 21, 2026 07:00

sfc-gh-fpawlowski force-pushed the graphite-base/4321 branch from c8a6bc2 to 8255b78 Compare August 21, 2026 08:35

sfc-gh-fpawlowski force-pushed the SNOW-2912540-log-batch-mock-patch branch from dc6bd66 to a654ad9 Compare August 21, 2026 08:35

sfc-gh-fpawlowski changed the base branch from graphite-base/4321 to SNOW-2912540-request-id-compat August 21, 2026 08:35

snowflake-security-bot Bot reviewed Aug 21, 2026

View reviewed changes

sfc-gh-fpawlowski changed the base branch from SNOW-2912540-request-id-compat to graphite-base/4321 August 21, 2026 09:36

sfc-gh-fpawlowski force-pushed the graphite-base/4321 branch from 8255b78 to cec387a Compare August 21, 2026 09:37

sfc-gh-fpawlowski force-pushed the SNOW-2912540-log-batch-mock-patch branch from a654ad9 to 98c0936 Compare August 21, 2026 09:37

sfc-gh-fpawlowski changed the base branch from graphite-base/4321 to SNOW-2912540-request-id-compat August 21, 2026 09:37

snowflake-security-bot Bot reviewed Aug 21, 2026

View reviewed changes

sfc-gh-fpawlowski force-pushed the SNOW-2912540-log-batch-mock-patch branch from 98c0936 to 2257b69 Compare August 21, 2026 09:59

snowflake-security-bot Bot reviewed Aug 21, 2026

View reviewed changes

This was referenced Aug 21, 2026

SNOW-2912540: CI autofix follow-up (empty base for sf ai worker) #4325

Closed

SNOW-2912540: mock _connect on v5 so local testing skips UD connection_init #4326

Open

SNOW-2912540: remap write_pandas missing-table errors via ProgrammingError.raw_msg #4328

Open

sfc-gh-yuwang approved these changes Aug 26, 2026

View reviewed changes

Navigation Menu

Uh oh!

SNOW-2912540: mock-patch try_add_log_to_batch instead of reading _log_batch - #4321

SNOW-2912540: mock-patch try_add_log_to_batch instead of reading _log_batch#4321
sfc-gh-fpawlowski wants to merge 1 commit into
SNOW-2912540-request-id-compatfrom
SNOW-2912540-log-batch-mock-patch

sfc-gh-fpawlowski commented Aug 20, 2026

Uh oh!

sfc-gh-fpawlowski commented Aug 20, 2026 •

edited

Loading

Uh oh!

snowflake-security-bot Bot left a comment

Uh oh!

snowflake-security-bot Bot left a comment

Uh oh!

snowflake-security-bot Bot left a comment

Uh oh!

snowflake-security-bot Bot left a comment

Uh oh!

codecov-commenter commented Aug 20, 2026 •

edited

Loading

Uh oh!

snowflake-security-bot Bot left a comment

Uh oh!

snowflake-security-bot Bot left a comment

Uh oh!

snowflake-security-bot Bot left a comment

Uh oh!

snowflake-security-bot Bot left a comment

Uh oh!

snowflake-security-bot Bot left a comment

Uh oh!

snowflake-security-bot Bot left a comment

Uh oh!

snowflake-security-bot Bot left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

sfc-gh-fpawlowski commented Aug 20, 2026

Uh oh!

sfc-gh-fpawlowski commented Aug 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

snowflake-security-bot Bot left a comment

Choose a reason for hiding this comment

Snowflake Security Review

Uh oh!

snowflake-security-bot Bot left a comment

Choose a reason for hiding this comment

Snowflake Security Review

Uh oh!

snowflake-security-bot Bot left a comment

Choose a reason for hiding this comment

Snowflake Security Review

Uh oh!

snowflake-security-bot Bot left a comment

Choose a reason for hiding this comment

Snowflake Security Review

Uh oh!

codecov-commenter commented Aug 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

snowflake-security-bot Bot left a comment

Choose a reason for hiding this comment

Snowflake Security Review

Uh oh!

snowflake-security-bot Bot left a comment

Choose a reason for hiding this comment

Snowflake Security Review

Uh oh!

snowflake-security-bot Bot left a comment

Choose a reason for hiding this comment

Snowflake Security Review

Uh oh!

snowflake-security-bot Bot left a comment

Choose a reason for hiding this comment

Snowflake Security Review

Uh oh!

snowflake-security-bot Bot left a comment

Choose a reason for hiding this comment

Snowflake Security Review

Uh oh!

snowflake-security-bot Bot left a comment

Choose a reason for hiding this comment

Snowflake Security Review

Uh oh!

snowflake-security-bot Bot left a comment

Choose a reason for hiding this comment

Snowflake Security Review

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sfc-gh-fpawlowski commented Aug 20, 2026 •

edited

Loading

codecov-commenter commented Aug 20, 2026 •

edited

Loading