Open
Conversation
whwoohw
reviewed
Jun 7, 2023
whwoohw
left a comment
whwoohw
left a comment
There was a problem hiding this comment.
잘 작성하셨습니다!
간단한 의문점이나 수정하면 좋을만한 사항들 적어놨으니
코멘트 달아주시거나 수정할 부분 수정해서 merge까지 해주세요!
Comment on lines
+7
to
+10
| const [email, setEmail] = useState(""); | ||
| const [username, setUsername] = useState(""); | ||
| const [college, setCollege] = useState(""); | ||
| const [major, setMajor] = useState(""); |
There was a problem hiding this comment.
굳이 여러 state를 쓰지말고, 하나의 formdata에 넣는게 효율적으로 보입니다!
Comment on lines
+27
to
+30
| setEmail(info.user.email); | ||
| setUsername(info.user.username); | ||
| setCollege(info.college); | ||
| setMajor(info.major); |
There was a problem hiding this comment.
Suggested change
| setEmail(info.user.email); | |
| setUsername(info.user.username); | |
| setCollege(info.college); | |
| setMajor(info.major); | |
| set�FormData({ | |
| email : info.user.email, | |
| username: info.user.username, | |
| college : info.college, | |
| major : info.major, | |
| }); |
위에서 이어진 내용으로, 저라면 이렇게 할 것 같습니다!
Comment on lines
+15
to
+17
| useEffect(() => { | ||
| setContent(infoContent); | ||
| }, [infoContent]); |
| const handleEditInfo = (e) => { | ||
| e.preventDefault(); | ||
| updateInfo({ [infoLabel]: content }); | ||
| setContent(infoContent); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.