fix: Tap Test improvements/fixes #4145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The output can contain ansi escape sequences which must be stripped to ensure consistent test behavior.
node-tap automatically runs tests in parallel instead of one at at time. See: https://node-tap.org/changelog/#130---2019-04-25 node-tap 15.0 changed the behavior of teardown, making it asynchronous. See: https://node-tap.org/changelog/#150---2021-03-30 Therefore one tap tests may be running while another runs or while another has finished running but hasn't finished executing teardown. With all tests using the same port, 12345, multiple tests would try to start a server on that port at the same time resulting it tests randomly failing with: listen EADDRINUSE: address already in use :::12345 Using a different port per process eliminates this problem. See: https://node-tap.org/docs/api/parallel-tests/
Since tap tests can run in parallel, if multiple tap tests use the same configuration directory and they try to update configuration, they'll overwrite each other and end up in indeterminate states, causing unexpected test failures.
|
@PeterSchafer hopefully this small PR passes all tests and is very easy to merge :) |
candrews
changed the title
|
Parallelism support added in: #4989 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Supports parallelism in the tap tests by using different XDG Configuration directories and fakeserver ports for each tap test process.
Also fixes a few minor problems in the tap tests.
Where should the reviewer start?
Run the tap tests.
How should this be manually tested?
npm run test:tapAny background context you want to provide?
I'm splitting out some of the changes in #3875 into separate PRs for easier review/merging.
What are the relevant tickets?
n/a
Screenshots
n/a
Additional questions
n/a