chore: add IPC acceptance tests #5777
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CatalinSnyk
force-pushed
the
chore/ipc-acceptance-tests
branch
from
1d55923 to
168a5b8
Compare
PeterSchafer
reviewed
Mar 7, 2025
test/jest/acceptance/ipc.spec.ts
Outdated
| ); | ||
|
|
||
| expect(code).toEqual(0); | ||
| expect(stderr).not.toContain('Error file contained '); |
There was a problem hiding this comment.
Question: Asserting against stderr/debug logs has been proven in the past as a quite unstable contract. Is this really what needs to be done here?
CatalinSnyk
force-pushed
the
chore/ipc-acceptance-tests
branch
from
168a5b8 to
e6f0252
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Submission Checklist
What does this PR do?
Adds some acceptance tests for the IPC, including assertions around the debug logs for the missing part of CLI-755
Where should the reviewer start?
How should this be manually tested?
What's the product update that needs to be communicated to CLI users?