minor refactoring (#205)

social-protocols · Sep 11, 2024 · f9eac5b · f9eac5b
1 parent 9cdd6a0
commit f9eac5b
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 24 deletions.
diff --git a/app/repositories/post.ts b/app/repositories/post.ts
@@ -19,7 +19,7 @@ import { checkIsAdminOrThrow } from '../utils/auth.server.ts'
 
 export async function createPost(
 	trx: Transaction<DB>,
-	parentId: number | null, // TODO: use parentId?: number
+	parentId: number | null,
 	content: string,
 	authorId: string,
 	options?: { isPrivate: boolean; withUpvote?: boolean; createdAt?: number },
@@ -52,18 +52,6 @@ export async function createPost(
 	return persistedPost.id
 }
 
-export async function initPostStats(trx: Transaction<DB>, postId: number) {
-	await trx
-		.insertInto('PostStats')
-		.values({
-			postId: postId,
-			replies: 0,
-		})
-		// ignore conflict
-		.onConflict(oc => oc.column('postId').doNothing())
-		.execute()
-}
-
 export async function incrementReplyCount(
 	trx: Transaction<DB>,
 	postId: number,
@@ -78,6 +66,17 @@ export async function incrementReplyCount(
 		.execute()
 }
 
+export async function initPostStats(trx: Transaction<DB>, postId: number) {
+	await trx
+		.insertInto('PostStats')
+		.values({
+			postId: postId,
+			replies: 0,
+		})
+		.onConflict(oc => oc.column('postId').doNothing())
+		.execute()
+}
+
 export async function getPost(
 	trx: Transaction<DB>,
 	postId: number,
@@ -137,17 +136,10 @@ export async function getStatsPost(
 	let query = trx
 		.selectFrom('Post')
 		.innerJoin('FullScore', 'FullScore.postId', 'Post.id')
-		// TODO: check if this join is even necessary
-		.leftJoin('PostStats', join =>
-			join.onRef('PostStats.postId', '=', 'Post.id'),
-		)
 		.leftJoin('Poll', 'Poll.postId', 'Post.id')
 		.selectAll('Post')
 		.selectAll('FullScore')
 		.selectAll('Poll')
-		.select(eb =>
-			eb.fn.coalesce(sql<number>`replies`, sql<number>`0`).as('nReplies'),
-		)
 		.where('Post.id', '=', postId)
 
 	const scoredPost = (await query.execute())[0]
@@ -279,7 +271,7 @@ export async function getDescendantCount(
 	return result.count
 }
 
-export async function getDescendants(
+export async function getDescendantIds(
 	trx: Transaction<DB>,
 	postId: number,
 ): Promise<number[]> {

diff --git a/app/repositories/ranking.ts b/app/repositories/ranking.ts
@@ -16,7 +16,7 @@ import { type DB } from '../types/kysely-types.ts'
 import { relativeEntropy } from '../utils/entropy.ts'
 import {
 	getDescendantCount,
-	getDescendants,
+	getDescendantIds,
 	getPost,
 	getReplyIds,
 	getPostWithScore,
@@ -52,7 +52,7 @@ export async function getCommentTreeState(
 	targetPostId: number,
 	userId: string | null,
 ): Promise<CommentTreeState> {
-	const descendantIds = await getDescendants(trx, targetPostId)
+	const descendantIds = await getDescendantIds(trx, targetPostId)
 
 	const results = await trx
 		.selectFrom('Post')

diff --git a/app/routes/fallacyDetection.tsx b/app/routes/fallacyDetection.tsx
@@ -24,7 +24,7 @@ export default function BullShredder() {
 	>(latestPlaygroundPosts)
 
 	const infoText = `
-# Welcome to Jabble!
+# Jabble Fallacy Detection
 
 This tool analyzes your posts for [rhetorical fallacies](https://en.wikipedia.org/wiki/Fallacy).
 You can use it to review your own social media posts or to detect whether someone else is trying to manipulate you.