Repository navigation
Fix contributor docs - #39
Merged
Merged
Conversation
The CI test step carried PYTHONPATH=tests/gym_tests with a comment claiming gym_tests needs it to import spec_list. It does not: that directory has no __init__.py, so pytest prepends it to sys.path itself. Verified by running the CI command with PYTHONPATH unset, which collects and passes all 92 tests. The setting was redundant and the comment asserted something untrue. CONTRIBUTING did not mention linting, which CI now enforces through lint.sh. Anyone following it exactly got a green local run and a red pull request on formatting. Add the lint step and say which tools run, rather than the previous generic reference to PEP8. Co-Authored-By: Claude <noreply@anthropic.com>
The repository moved from the zykls organisation, but the README, docs and two notebooks still linked to zykls. GitHub redirects transferred repositories, so the links resolved, but they misreport where the project lives. Left github.com/zykls/whynot_estimators alone in five places. That is a separate project which has not moved: socialfoundations/whynot_estimators does not exist, so rewriting those would have broken working links. The match therefore requires the next character to be / or . rather than matching the repository name as a prefix. Includes the CI badge, which this branch's predecessor added pointing at zykls and which consequently rendered nothing. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #38. Three small fixes, no behaviour change.
PYTHONPATH: tests/gym_testsfrom CI. It was redundant and itscomment claimed otherwise:
tests/gym_tests/has no__init__.py, so pytestprepends it to
sys.pathitself. Verified by running the CI command withPYTHONPATHunset — 92 tests collected and passing. A green test job here isthe confirmation on both platforms.
never mentioned it, so following it exactly gave a clean local run and a red
PR on formatting.
socialfoundations. README, docs and twonotebooks still said
zykls. GitHub redirects transfers so they resolved,but they misreported where the project lives. This includes the CI badge,
which Make WhyNot run on current Python and dependencies #38 added pointing at
zyklsand which therefore rendered nothing.github.com/zykls/whynot_estimatorsis deliberately left alone in fiveplaces — that is a separate project which has not moved
(
socialfoundations/whynot_estimatorsdoes not exist), so rewriting it wouldbreak working links. The replacement requires the next character to be
/or.rather than matching the repository name as a prefix.