Skip to content

fix(e2e): make the debugger assertions fail when the debugger is not connected #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
latekvo wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Draft

fix(e2e): make the debugger assertions fail when the debugger is not connected #704

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions scripts/e2e-full/phases/50-rn-bluesky.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,14 @@ run_phase() {
local D="\"device_id\":\"$LID\",\"port\":$MPORT"

# --- debugger chain -------------------------------------------------------
assert_ok "$P" debugger-status status "{$D}"
# Both of these answer 200 while reporting that the debugger is NOT connected,
# so the exit code alone says only that the server replied. debugger-status
# carries `connected`; debugger-log-registry does not, and reports the same
# state through `status` (absent on a healthy call, "not_connected" when the
# runtime is unreachable).
assert_true "$P" debugger-status status "{$D}" '.connected'
assert_field "$P" debugger-evaluate eval "{$D,\"expression\":\"1+1\"}" '(.result|tostring)' '2'
assert_ok "$P" debugger-log-registry logs "{$D}"
assert_field "$P" debugger-log-registry logs "{$D}" '(.status // "connected")' 'connected'
assert_ok "$P" debugger-component-tree tree "{$D}"
assert_ok "$P" debugger-inspect-element inspect "{$D,\"x\":0.5,\"y\":0.5}"
assert_ok "$P" debugger-reload-metro reload "{$D}"
Expand Down