[RNE Rewrite] style(ts): standardize task naming, preprocessor options, and TSDoc conventions - #1340
Merged
Merged
Conversation
…ticSegmenterModel
…tyleTransferOptions
barhanc
added
refactoring
improvement
msluszniak
reviewed
Jul 31, 2026
| * @param options.confidenceThreshold Minimum confidence score for returned | ||
| * detections. | ||
| * @param options.iouThreshold Non-maximum suppression IoU threshold. | ||
| * @param options.confidenceThreshold Minimum confidence score threshold. If |
Member
There was a problem hiding this comment.
options and opts, I don't know if this won't cause a confusion.
Member
Author
There was a problem hiding this comment.
Good catch. Renamed opts inside model configs to modelOpts across the board.
msluszniak
reviewed
Aug 3, 2026
Rename the property on CV model types to to disambiguate from per-call parameters and low-level op parameters.
Replace inline enumerations (e.g., `stretch`, `letterbox`, `crop`)
with {@link} references to the named types. Expand 'IoU' to
'Intersection over Union (IoU)' for consistency.
- Replace terse modelOpts comments with descriptions of what they
control, linking to the proper options type
- Add {@link} type references to property descriptions
- Expand 'IoU' to 'Intersection over Union (IoU)' for consistency
- Collapse multi-line JSDoc to single-line where it fits in 100 chars
- Mention 'stretch' as only resizeMode value where applicable
msluszniak
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Naming Consistency: Standardized
ClassifierModel.opts(renamed fromclassifierOpts) andSemanticSegmenterModel/SemanticSegmenterOptions(renamed fromSemanticSegmentationModel).Preprocessor Options: Replaced top-level
alpha/betafields with a requirednormalizeOpts: NormalizeOptionsproperty across all task option interfaces andmodels.tspresets.TSDoc Standardization: Converted top-level
@propertytags to inline member JSDoc comments (/** ... */) and added function-level@param options.fieldfallback notes.Immutability: Enforced
readonlyproperty modifiers on task results (SemanticSegmentationResult,BoxMap).Introduces a breaking change?
Type of change
Tested on
Testing instructions
Screenshots
Related issues
Checklist
Additional notes