feat: Add NativeWorkletsModule #6378
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjzel
changed the base branch from
main
to
@tjzel/worklets/dirs-for-native-code
tjzel
force-pushed
the
@tjzel/worklets/dirs-for-native-code
branch
from
f53cd68
to
567ce36
Compare
tjzel
changed the base branch from
main
to
@tjzel/native-code-autosuggestions
tjzel
force-pushed
the
@tjzel/worklets/common-worklets-module
branch
from
6de33a7
to
d87a9e1
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 3, 2024
## Summary Taken those changes from #6378 for more granularity. I applied various suggestions coming from Android Studio and clangd. ## Test plan GitHub Actions +
tomekzaw
reviewed
Sep 3, 2024
packages/react-native-reanimated/Common/cpp/reanimated/NativeModules/NativeReanimatedModule.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/Common/cpp/reanimated/NativeModules/NativeReanimatedModule.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/Common/cpp/reanimated/NativeModules/NativeReanimatedModule.cpp
Outdated
Show resolved
Hide resolved
| @@ -265,10 +183,10 @@ jsi::Value NativeReanimatedModule::registerEventHandler( | |||
| rt, worklet, "[Reanimated] Event handler must be a worklet."); | |||
| int emitterReactTagInt = emitterReactTag.asNumber(); | |||
|
|
|||
| uiScheduler_->scheduleOnUI([=] { | |||
| NativeWorkletsModule_->getUIScheduler()->scheduleOnUI([=, this] { | |||
There was a problem hiding this comment.
How about exposing scheduleOnUI directly from NativeWorkletsModule? Actually, we could do the same for scheduleOnJS.
There was a problem hiding this comment.
Good idea, but let's save it for the follow-up PR.
packages/react-native-reanimated/Common/cpp/reanimated/NativeModules/NativeReanimatedModule.h
Outdated
Show resolved
Hide resolved
...act-native-reanimated/Common/cpp/reanimated/RuntimeDecorators/REAWorkletRuntimeDecorator.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/Common/cpp/worklets/NativeModules/NativeWorkletsModule.cpp
Outdated
Show resolved
Hide resolved
packages/react-native-reanimated/Common/cpp/worklets/NativeModules/NativeWorkletsModule.h
Outdated
Show resolved
Hide resolved
6 tasks
|
Sunsetting this PR. I will split it into more PRs for the ease of review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request is another part of the effort of bringing
react-native-workletsto life. Here I createdNativeWorkletsModuleto split the responsibilities ofNativeReanimatedModule. I basically split all the native code (C++, Java, Obj-C) into compilation-wise structures between Worklets and Reanimated, instead of directory-wise only as previously.Test plan