refactor(test): test-tabs-appearance-defined-by-selected-tab#4179
Open
LKuchno wants to merge 5 commits into
Open
refactor(test): test-tabs-appearance-defined-by-selected-tab#4179LKuchno wants to merge 5 commits into
LKuchno wants to merge 5 commits into
Conversation
… configs, adding badge value, new scenario created and scenario-description file updated with details and e2e coverage
LKuchno
force-pushed
the
@lkuchno/test-tabs-appearance-defined-by-selected-tab
branch
from
e196d71 to
170929a
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the manual “single-feature” tabs test screen to verify that the native tab bar appearance updates dynamically based on the currently selected tab, and adds/updates the associated scenario metadata and documentation.
Changes:
- Refactored the
test-tabs-appearance-defined-by-selected-tabtest screen to derive per-tab appearance from shared iOS/Android defaults with per-tab overrides (including a Tab3 badge). - Added a new manual
scenario.mddescribing expected per-tab appearance outcomes across iOS/Android. - Updated the scenario metadata (
scenario-description.ts) to includedetails, adjust the display name, and mark E2E coverage as incomplete.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 10 comments.
| File | Description |
|---|---|
| apps/src/tests/single-feature-tests/tabs/test-tabs-appearance-defined-by-selected-tab/index.tsx | Refactors per-tab appearance configuration and adds a badge to exercise appearance changes when switching selected tabs. |
| apps/src/tests/single-feature-tests/tabs/test-tabs-appearance-defined-by-selected-tab/scenario.md | New manual test scenario describing expected visual outcomes for tab-specific appearance updates. |
| apps/src/tests/single-feature-tests/tabs/test-tabs-appearance-defined-by-selected-tab/scenario-description.ts | Updates scenario metadata (name/details/e2eCoverage) used by the in-app scenario list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+54
to
+56
| 1. Launch the app and navigate to the | ||
| **Tab Bar Appearance Per Selected Tab** screen. | ||
|
|
Comment on lines
+121
to
+123
| 1. Launch the app and navigate to the | ||
| **Tab Bar Appearance Per Selected Tab** screen. | ||
|
|
Comment on lines
128
to
129
| scrollEdgeAppearance: { | ||
| ...DEFAULT_APPEARANCE_IOS, |
Comment on lines
192
to
193
| scrollEdgeAppearance: { | ||
| ...DEFAULT_APPEARANCE_IOS, |
The appearance-defined-by-selected-tab screen configured iOS appearance only via scrollEdgeAppearance. Because the native layer assigns each item a non-nil empty standardAppearance when unset, there is no fallback to scrollEdgeAppearance — so if iOS ever selects the standard appearance (scrollable content added, or a version that prefers it for non-scrolling bars) the per-tab colors silently revert to system defaults. Extract per-tab iOS appearances into shared constants and set both standardAppearance and scrollEdgeAppearance from them across all three tabs, so the configured look holds regardless of which appearance UIKit selects. Also drop the now-inaccurate per-property wording from the scenario description. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…tation as configuration is set for stacked layout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactors the single-feature test screen and adds scenario for
test-tabs-appearance-defined-by-selected-tab, which verifies that the native tab bar dynamically updates to reflect the appearance/styling defined by the currently selected tab.The screen exercises per-tab tab bar appearance across iOS and Android: tab bar background, icon and title colors for normal/selected/focused states, active indicator, badge text/background colors, and title font options. Each of three tabs defines a distinct appearance so switching tabs (via the native bar or in-screen buttons) is visibly reflected in the bar.
Closes: https://github.com/software-mansion/react-native-screens-labs/issues/1533
Changelog
.../test-tabs-appearance-defined-by-selected-tab/index.tsx— refactored test screen; per-tab appearance configs derived from sharedDEFAULT_APPEARANCE_IOS/DEFAULT_APPEARANCE_ANDROIDdefaults with per-tab overrides; addedbadgeValueon Tab3..../test-tabs-appearance-defined-by-selected-tab/scenario.md— new manual test scenario with iOS/Android steps and expected per-tab color results, including badge value notes..../test-tabs-appearance-defined-by-selected-tab/scenario-description.ts— addeddetailsfield and set name to "Tab-Specific Appearance".Test visual documentation
android.mov
ios18.6.mov
ios26.5.mov