refactor(test): align tabs test structure with rules from rfc#4180
refactor(test): align tabs test structure with rules from rfc#4180LKuchno wants to merge 7 commits into
Conversation
…gation controller scenario
…dden and experimental_userInterfaceStyle tests files
…ns into @lkuchno/test-structure-fix
LKuchno
changed the title
| key: 'test-tabs-screen-orientation', | ||
| platforms: ['ios'], |
There was a problem hiding this comment.
Is it iOS specific? I don't think it is. Maybe it's yet unimplemented for Android, however the test is intended for both platforms, for Android it just fails.
There was a problem hiding this comment.
Yes, it's currently unimplemented on Android tracked here: #868.
I plan to add the 'android' tag to #1208 once it's actually working. There are also separate iOS and iPad-specific issues that will require scenario updates. For now, I'm preparing a basic scenario to verify 3 out of the 10 possible options (according to the docs).
I feel it might be misleading to place the Android icon next to a screen that doesn't work on that platform yet. However, I can add it if preferred, trusting that the note about the current iOS-only implementation in the scenario description will be enough context.
…work on both platform just waiting for android implementation
2 participants
Description
This PR cleans up the tabs single-feature test suite so directory names, e2e
file names, and
scenario-descriptionmetadata follow the project's testorganization conventions. It is a test-infrastructure-only change — no library
source or runtime behavior is touched.
Changes
tabs-screen-orientationtest directory totest-tabs-screen-orientation(bothindex.tsxandscenario-description.ts)to match the
test-*naming convention, and updated its registrationkeyaccordingly.
test-tabs-bottom-accessory-ios.e2e.ts→test-tabs-bottom-accessory-layout-ios.e2e.tsso the e2e file mirrors itstest screen directory.
index.tsfor aconsistent, logical order.
detailsmetadata to thescenario-description.tsfiles fortest-tabs-tab-bar-hiddenandtest-tabs-tab-bar-experimental-user-interface-style-ios.keyin thetest-tabs-more-navigation-controller-iosscenario-description to carry the missing
-iossuffix.scenario.mdmetadata (e2e test section reference) fortest-tabs-layout-appearances-iosto match the new e2e file naming.New Tabs screen order:
