Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SvgXml compatibility with ReAnimated - [Help Needed] #1444

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

adkenyon
Copy link

Summary

Our app leverages in combination with babel-plugin-inline-import for our Iconography. The Issue we've run into is that we're not able to use Reanimated with the fill property in order to animated icon color changes.

I've gotten the solution to work on iOS but I'm having no luck on Android. It'd be awesome if someone with Android knowledge be able to chip in.

The iOS solution was fairly straightforward.

  • Use React.forwardRef to expose the internal element from
  • On 's setNativeProps function I split the props into two groups; those pertaining to the root element and those pertaining to the child element.

Test Plan

I tested the changes using our organizations app. I was successful on iOS while Android does not show the icon at all.

Compatibility

OS Implemented
iOS
Android

Checklist

  • I have tested this on a device and a simulator
  • I added documentation in README.md
  • I updated the typed files (typescript)
  • I added a test for the API in the __tests__ folder

@adkenyon adkenyon force-pushed the support-reanimated-for-svgxml branch from 18eba33 to f535b9d Compare November 20, 2020 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant