Remove redundant Context::remaining_accounts lifetime#4069
Closed
andreisilviudragnea wants to merge 4 commits intosolana-foundation:masterfrom
Closed
Remove redundant Context::remaining_accounts lifetime#4069andreisilviudragnea wants to merge 4 commits intosolana-foundation:masterfrom
andreisilviudragnea wants to merge 4 commits intosolana-foundation:masterfrom
Conversation
|
@andreisilviudragnea is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
andreisilviudragnea
force-pushed
the
clean-context
branch
2 times, most recently
from
4e6df9f to
465f1f5
Compare
andreisilviudragnea
force-pushed
the
clean-context
branch
from
465f1f5 to
e999231
Compare
Collaborator
|
#3340 is an alternate approach to eliminating all but |
jamie-osec
changed the title
jamie-osec
approved these changes
Dec 4, 2025
Contributor
|
@jamie-osec Since V2 will use pinocchio, it will be possible to have a single lifetime – similar to #3340. |
Collaborator
|
Thanks for the PR - going to close this as it looks like #3340 and the move to Pinocchio will be a more robust solution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
Context::remaining_accounts, the'c: 'infoconstraint is always required, so replacing the'clifetime inpub remaining_accounts: &'c [AccountInfo<'info>],with'infosimplifies client code, as shown in MeteoraAg/damm-v2#138.This is a breaking change though and needs to be done carefully, but it would be nice to include this in v1.0.0 release.