feat: Add versioned tx support in rust client#4207
feat: Add versioned tx support in rust client#4207cryptopapi997 wants to merge 9 commits intosolana-foundation:masterfrom
Conversation
|
@cryptopapi997 is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
c114045 to
a3963f5
Compare
a3963f5 to
41d16f9
Compare
|
wdyt @jamie-osec |
|
I don't think deprecating here necessarily makes sense; the vast majority of use cases are going to be using legacy so it adds boilerplate to the common case. I think we can just use the docstring to point at the versioned method |
My thinking was to have a singular way to build & send transactions, however I see the value in keeping the base case as simple as possible also, so fine by me. Removed the deprecation & switched to just mentioning it in the comment |
abb578f to
a7d574a
Compare
|
addressed the review, lmk if this works @jamie-osec . I had a look at the CI failures, but those seem to be unrelated since they're all something related to something onchain invoked via the ts client (neither of which this PR modifies) |
|
Changes LGTM, will rerun CI |
|
Can you fix the new conflict? |
Currently, there's no way to build versioned txs using the anchor rust client, only legacy transactions are possible. This PR changes that by introducing the same transaction-related method with a
_versionedsuffix & deprecates the old methods. This is relevant in that it allows for switching between V0 and legacy transactions with the same code (and the upcoming V1 format).