Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On several occasions I have accidentally pulled-to-refresh my browser and lost my scoring after 5+ minutes in.
This PR aims to prevent lost of scoring progress by saving your game state in
LocalStorage. WhenCreateGameViewis loaded, your previous state will be restored and you will be redirected to theForestViewautomatically.Once you're done with scoring, or start scoring a new game, your old game state will be cleared.
After an app version update, your game state from the previous app version will not be loaded anymore.
This PR also fixes what I believe was an issue with the QR code importing - the cards that got imported were not removed from the
Game.deckstate, but now they are. SeeimportPlayerDatainsrc/game/sharing/import.tsfor those changes.Disclaimer: I don't have experience with React