projection bugfix #20
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brenelz
commented
Jun 23, 2025
| @@ -28,7 +28,7 @@ export function wrapProjection<T>( | |||
|
|
|||
| function wrap(source, node, wrapped) { | |||
| if (wrapped.has(source)) return wrapped.get(source); | |||
| const wrap = new Proxy(source, { | |||
| const innerWrap = new Proxy(source, { | |||
| get(target, property) { | |||
| node.read(); | |||
| const v = target[property]; | |||
There was a problem hiding this comment.
i believe the below wrap(v, node, wrapped) function call was using the proxy variable instead of the function itself
There was a problem hiding this comment.
You are correct.. I am reworking this right now so I will keep this fix in mind.
There was a problem hiding this comment.
So can probably just close this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting this weird
wrap is not a function errorwith projections.My suspicion is that that
wrap(v, node, wrapped) :was using the wrongwrapvariable since they were named the same.Thus to fix the issue called it a different name like
innerWrap