Remove "variables" from createEffect dependency examples - #1269
Merged
Conversation
Removed "variables" from the types of things that createEffect tracks changes of. It was confusing and incorrect except for variables that hold reactive values. https://www.reddit.com/r/solidjs/comments/1nex5ei/why_does_solidjs_docs_list_variables_as_a/ https://playground.solidjs.com/anonymous/086d4c92-c72f-4d9f-bd44-4821080bab61
|
|
❌ Deploy Preview for solid-docs failed. Why did it fail? →
|
LadyBluenotes
approved these changes
Sep 17, 2025
LadyBluenotes
pushed a commit
that referenced
this pull request
Sep 17, 2025
LadyBluenotes
pushed a commit
that referenced
this pull request
Nov 13, 2025
LadyBluenotes
pushed a commit
that referenced
this pull request
Nov 13, 2025
LadyBluenotes
pushed a commit
that referenced
this pull request
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed "variables" from the list of the types of things that createEffect tracks changes of. It was confusing and incorrect except for variables that hold reactive values.