Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the devise-specific fields from spree_users #4440

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

elia
Copy link
Member

@elia elia commented Jun 24, 2022

Let solidus_auth_devise add and maintain the fields it needs.

Extracted from #3923

Description

Checklist:

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have updated Guides and README accordingly to this change (if needed)
  • I have added tests to cover this change (if needed)
  • I have attached screenshots to this PR for visual changes (if needed)

@elia elia mentioned this pull request Jun 24, 2022
4 tasks
@waiting-for-dev
Copy link
Contributor

@elia, I think that if you rebase from master CI will be green 🪄

@elia elia force-pushed the elia/remove-devise-specific-fields-from-user-migration branch from 2db1253 to 531b5f7 Compare July 18, 2022 07:45
@waiting-for-dev
Copy link
Contributor

Hey, @elia, is it ready for review? 🙂

@kennyadsl kennyadsl added the type:enhancement Proposed or newly added feature label Aug 22, 2022
@waiting-for-dev waiting-for-dev added the changelog:solidus_core Changes to the solidus_core gem label Aug 30, 2022
@elia elia force-pushed the elia/remove-devise-specific-fields-from-user-migration branch from 531b5f7 to 579dce6 Compare October 3, 2022 11:07
@waiting-for-dev waiting-for-dev removed the type:enhancement Proposed or newly added feature label Jan 16, 2023
@fthobe
Copy link
Contributor

fthobe commented Feb 8, 2025

@elia did this ever make it over the finish line?

Let solidus_auth_devise add and maintain the fields it needs.
@elia elia force-pushed the elia/remove-devise-specific-fields-from-user-migration branch from 579dce6 to 73f2c4c Compare February 8, 2025 18:44
@elia
Copy link
Member Author

elia commented Feb 8, 2025

@fthobe no, it needs those columns to be added individually in solidus_auth_devise first, not a difficult change if the CI is in good shape

@fthobe
Copy link
Contributor

fthobe commented Feb 8, 2025

I saw only a migration failing, do you want to give it another try by re triggering?

You were quicker

@elia
Copy link
Member Author

elia commented Feb 8, 2025

No, it wouldn't change a thing, we remove columns here where they don't belong, but it won't pass until auth devise adds support for them if they're missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:solidus_core Changes to the solidus_core gem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants