-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the devise-specific fields from spree_users #4440
base: main
Are you sure you want to change the base?
Remove the devise-specific fields from spree_users #4440
Conversation
@elia, I think that if you rebase from master CI will be green 🪄 |
2db1253
to
531b5f7
Compare
Hey, @elia, is it ready for review? 🙂 |
531b5f7
to
579dce6
Compare
@elia did this ever make it over the finish line? |
Let solidus_auth_devise add and maintain the fields it needs.
579dce6
to
73f2c4c
Compare
@fthobe no, it needs those columns to be added individually in solidus_auth_devise first, not a difficult change if the CI is in good shape |
You were quicker |
No, it wouldn't change a thing, we remove columns here where they don't belong, but it won't pass until auth devise adds support for them if they're missing. |
Let solidus_auth_devise add and maintain the fields it needs.
Extracted from #3923
Description
Checklist: