Admin stock locations form #6160
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaimann
force-pushed
the
admin-stock-locations-form
branch
from
2acc0de to
17d8f3d
Compare
github-actions
bot
added
the
changelog:solidus_legacy_promotions
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6160 +/- ##
==========================================
+ Coverage 88.81% 88.91% +0.10%
==========================================
Files 835 839 +4
Lines 18153 18202 +49
==========================================
+ Hits 16122 16184 +62
+ Misses 2031 2018 -13 ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
changelog:solidus_core
chaimann
force-pushed
the
admin-stock-locations-form
branch
from
2ee470c to
8c92d69
Compare
github-actions
bot
removed
the
changelog:solidus_legacy_promotions
chaimann
force-pushed
the
admin-stock-locations-form
branch
3 times, most recently
from
526a065 to
95992db
Compare
As a common resource controller make it inherit from ResourcesController.
Changes description: - introduced `@include_name_field` flag that controls whether to show "Name" field on the form; - renamed keyword `address` to `addressable` to better reflect that the nature of the passed object; - renamed keyword `name` to `fieldset_name` to avoid confusion with "Name" field, whereas `fieldset_name` is a name to be used for the form (e.g. "users[billing_address_attributes]"); Motivation: This change allows to reuse this component in location stock form component, where the only difference between forms is that "Name" field is not there for location stock address. Also, maybe it'll be sensible in the future to migrate stock location to use a `stock_location_address` association and remove all the address related fields from the `stock_location` table, but for now it's quite a big task to be contained in current scope. So for now, just treat `stock_location` as an `addressable` which can be used to render address form component.
This is the first step to refactor checkbox component, so it can be used as a separate element or as a form control.
Motivation: We have a couple of places throughout the admin where checkboxes are used as part of a form, with all the same elements being reused to construct a checkbox field: - label with some caption; - hidden input field to support sending a "0" value in request; - optional toggletip hint; Few places however lacked the hidden input, therefore the form was not submitting the "0" value correctly. This updated component builds a reusable form checkbox, that encapsulates all the needed layout and logic for a form checkbox to be displayed and work properly, with an interface to customise it to each form needs.
chaimann
force-pushed
the
admin-stock-locations-form
branch
from
95992db to
c0d25ea
Compare
|
test failure seems to be one of those intermittent |
|
@kennyadsl @tvdeyen hey guys, you might have missed this one, can I get some eyes 👀 please? |
tvdeyen
reviewed
Mar 16, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a page with form for stock locations create/update, as well as updates stock locations table with links to go to edit page.
Updates "ui/forms/checkbox" component to contain common layout and logic reused between all checkboxes in admin forms, separating a "checkbox" component as a single element into its own component "ui/checkbox".
Adds helper methods
.back,.discardand.savefor UI button componentsAdds missing tests for refund reasons, tax categories and product forms, where missing hidden input prevented booleans to be saved properly.
Page screenshot:
There are a few differences from the design card which I believe make sense to have:
emailcolumn instock_locations, and the "Phone" field is included in "ui/forms/address", so "Phone" field is not placed in its own section;Checklist