FIX SQLException: no such column: spree_promotions.match_policy

[ringe]

Summary

New Solidus install on existing app fails due to legacy column not present.

Versions

gem "rails", "~> 8.0.1"
gem "solidus", "~> 4.5"
gem "solidus_support", ">= 0.12.0"
gem "solidus_support", ">= 0.12.0"
gem "solidus_admin", ">= 0.2"

Commands

bundle add solidus
bundle remove solidus_auth_devise
bin/rails generate solidus:install --no-sample --authentication=none --payment-method=none --mount-point=/shop --frontend=none

Checklist

• I agree that my PR will be published under the same license as Solidus.
• I have written a thorough PR description.
• I have kept my commits small and atomic.
• I have used clear, explanatory commit messages.

[kennyadsl]

Thanks @ringe! Can you add the versions used and which commands you executed for this error to happen?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.81%. Comparing base (7f148a4) to head (58501f3).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6177      +/-   ##
==========================================
+ Coverage   86.65%   88.81%   +2.16%     
==========================================
  Files         515      836     +321     
  Lines       11900    18164    +6264     
==========================================
+ Hits        10312    16133    +5821     
- Misses       1588     2031     +443     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[fthobe]

@ringe are you still interested into bringing this upstream?
Please also provide a detailed commit message.

[ringe]

@ringe are you still interested into bringing this upstream? Please also provide a detailed commit message.

I would like to bring this yes, what are you missing in the commit message?

[fthobe]

In your case a brief comment explaining the change and the origin of this issue if it's limited to certain versions.
You can find all details here: Contribution Guidelines

[jarednorman]

@ringe The PR/commit message is missing the answers to these questions:

1. What command were you running that resulted in the error?
2. What was the error?
3. Why is what your change the correct solution?

I think what you've found is a gotcha where you're using the new promo system, but a migration that depends on the old promo stuff is running, so your fix very well may be correct. It's just hard for me to know without a little more digging/context.

[fthobe]

@ringe you did great work here, can we get this over the finish line?

[ringe]

What command were you running that resulted in the error?
Unfortunately, I can't recreate the issue at the moment.
I tried adding solidus to an existing Rails 8 app at the time.

What was the error?
In case you run the SetPromotionsWithAnyPolicyToAllIfPossible migration after the :match_policy column was removed, or if it was never created - you get a "SQLException: no such column: spree_promotions.match_policy" error

Why is what your change the correct solution?
Maybe it isn't. Could be the install command should avoid generating this migration on a new install.
In case this migration is generated, this change avoids a crash by checking for the existence of the column before using it.
If the column do not exist, do not apply the migration.

I'm not sure what to write different in the commit message when I can't reproduce the error on a new rails 8.0.1 app.

[jarednorman]

Thanks for following up! I'm going to close this because you can't reproduce it, but if you (or anyone else) sees this issue, let's reopen this and get it resolved.

[ringe]

Thanks for your efforts and guidance. 😊