Localization and missing strings#6419
Open
nerijunior wants to merge 1 commit intosolidusio:mainfrom
Open
Conversation
tvdeyen
reviewed
Feb 21, 2026
|
|
||
| def title | ||
| model_class.model_name.human.pluralize | ||
| I18n.t("activerecord.models.#{model_class.model_name.i18n_key}", count: 2) |
Member
There was a problem hiding this comment.
We should use model.class.model_name.human instead. We can pass count: :many if we want to pluralize.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6419 +/- ##
=======================================
Coverage 89.50% 89.50%
=======================================
Files 981 981
Lines 20479 20479
=======================================
Hits 18330 18330
Misses 2149 2149 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nerijunior
force-pushed
the
njjjr/add-missing-locales
branch
from
e99f2e9 to
121e2e6
Compare
nerijunior
force-pushed
the
njjjr/add-missing-locales
branch
from
5ac0009 to
349ba58
Compare
jarednorman
requested changes
Apr 27, 2026
|
|
||
| def title | ||
| model_class.model_name.human.pluralize | ||
| I18n.t("activerecord.models.#{model_class.model_name.i18n_key}", count: 2) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
menu_items; (normalized with i18n-tasks`)orders/indextable to display localized strings for:order_state,payment_state, andshipment_state;Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs: