Skip to content

Don't "persist_amounts" in order recalculation #6451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jarednorman wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −2
Open

Don't "persist_amounts" in order recalculation #6451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion core/app/models/spree/in_memory_order_updater.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,6 @@ def recalculate_line_item_prices
end

def persist_totals
shipments.each(&:persist_amounts)
assign_item_totals
log_state_change("payment")
log_state_change("shipment")
Expand Down
1 change: 0 additions & 1 deletion core/spec/models/spree/in_memory_order_updater_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,7 +575,6 @@ module Spree

it "updates the shipment amount" do
expect(shipment).to receive(:assign_amounts)
expect(shipment).to receive(:persist_amounts)
updater.recalculate
end
end
Expand Down
Loading