Skip to content

Log refund gateway responses on payments #6452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BeastNectus wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Log refund gateway responses on payments #6452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions core/app/models/spree/refund.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,13 @@ def perform!
credit_cents = money.cents

@perform_response = process!(credit_cents)
log_entries.build(parsed_payment_response_details_with_fallback: perform_response)

self.transaction_id = perform_response.authorization
save!
transaction do
self.transaction_id = perform_response.authorization
save!

payment.log_entries.create!(parsed_payment_response_details_with_fallback: perform_response)
end

update_order
end
Expand Down
4 changes: 2 additions & 2 deletions core/spec/models/spree/refund_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,9 @@
expect(refund.reload.amount).to eq amount
end

it "creates a log entry" do
it "creates a payment log entry" do
subject
expect(refund.reload.log_entries).to be_present
expect(payment.reload.log_entries).to be_present
end

it "attempts to process a transaction" do
Expand Down