Fix FlatRate calculator to always return BigDecimal#6465
Open
PhodzoW0l7 wants to merge 1 commit intosolidusio:mainfrom
Open
Fix FlatRate calculator to always return BigDecimal#6465PhodzoW0l7 wants to merge 1 commit intosolidusio:mainfrom
PhodzoW0l7 wants to merge 1 commit intosolidusio:mainfrom
Conversation
The compute method was returning Integer 0 instead of BigDecimal when the currency didn't match or when no object was passed. This caused warnings like 'FlatRate#compute returned 0, it should return a BigDecimal'. Changes: - Wrap both return values in BigDecimal() explicitly - Added 4 tests asserting BigDecimal return type in all code paths Fixes solidusio#3756
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6465 +/- ##
=======================================
Coverage 89.66% 89.66%
=======================================
Files 990 990
Lines 20793 20793
=======================================
Hits 18645 18645
Misses 2148 2148 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jarednorman
requested changes
Apr 27, 2026
Member
jarednorman
left a comment
There was a problem hiding this comment.
Both linting issues need to be addressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compute method was returning Integer 0 instead of BigDecimal when the currency didn't match or when no object was passed. This caused warnings like 'FlatRate#compute returned 0, it should return a BigDecimal'.
Changes:
Fixes #3756
Summary
What does this PR do?
Fixes the FlatRate calculator to always return a BigDecimal.
Why is this needed?
Fixes #3756
The compute method returned Integer 0 instead of BigDecimal when
the currency didn't match or no object was passed, causing warnings:
"Spree::Calculator::FlatRate#compute returned 0, it should return a BigDecimal"
How was this tested?
Added 4 RSpec tests asserting BigDecimal return type across all code paths.
Checklist