feat(backend): Use Remixicons when new navbar is used#6478
Draft
tvdeyen wants to merge 6 commits intosolidusio:mainfrom
Draft
feat(backend): Use Remixicons when new navbar is used#6478tvdeyen wants to merge 6 commits intosolidusio:mainfrom
tvdeyen wants to merge 6 commits intosolidusio:mainfrom
Conversation
github-actions
Bot
added
changelog:solidus_backend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6478 +/- ##
==========================================
- Coverage 89.68% 88.07% -1.61%
==========================================
Files 991 700 -291
Lines 20832 14953 -5879
==========================================
- Hits 18683 13170 -5513
+ Misses 2149 1783 -366 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
We do not use HTML 4 anymore. This just causes spaces in these tables. We use CSS for that.
Never used and bad practice anyway. Use CSS for spacing not HTML 4 hacks.
The updated admin navbar also toggles the icons to remixicon, leading to a ugly mismatch of old fontawesome icons and the shiny new remixicons in the navbar.
If the new admin navbar is used we want to display remixicons instead of the outdated fontawesome ones. Addind a handlebars solidus_icon helper that automatically renders the correct iconset for us.
Instead of relying on fa- classes we add a common icon_button that resets button styles
Instead of relying on fa- icon classes for the action color, we use the data-action attribute
tvdeyen
force-pushed
the
backend-ri-icon-fixes
branch
from
4d7187d to
41371cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The updated admin navbar also toggles the icons to remixicon, leading to a ugly mismatch of old fontawesome icons and the shiny new remixicons in the navbar.
Since the new admin is still in heavy development and even when
solidus_adminis used the backend is used as fallback. We should be nice to our users and give them the new icons in the body as well if this is the case.Add a simple mapping to
link_to_with_icon(the helper we end up using for all icon based links), to make the remix iconsautomatically be used when the
Spree::Backend::Config.admin_updated_navbaris enabled.Screenshots
Before
Orders
Products
After
Orders
Products
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: