directresponse: Address several follow-up changes #10009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces several follow-up items that were captured during review for the initial direct response implementation PR: - Add the tech debt issue for improving reconciler watch behavior - Fix the direct response plugin reporting BackendNotFound when multiple DRs for a single rule were found - Assert on both the Accepted and ResolvedRef condition types in the translator test suite Signed-off-by: timflannagan <[email protected]>
|
Issues linked to changelog: |
lgadban
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit introduces several follow-up items that were captured during review for the initial direct response implementation PR:
See #9960 for the initial PR.
Checklist: