-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
project/gateway2: Replaces Endpoints with EndpointSlice for Creating Upstream Endpoints #10265
Merged
+577
−215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issues linked to changelog: |
Converted to draft as I troubleshoot e2e failures. |
yuval-k
reviewed
Nov 2, 2024
Likely there are some lookups that currently hard code to endpoints which may be causing the breaks |
yuval-k
reviewed
Nov 5, 2024
yuval-k
reviewed
Nov 5, 2024
yuval-k
reviewed
Nov 5, 2024
yuval-k
reviewed
Nov 5, 2024
timflannagan
reviewed
Nov 6, 2024
timflannagan
reviewed
Nov 6, 2024
Signed-off-by: Daneyon Hansen <[email protected]>
Signed-off-by: Daneyon Hansen <[email protected]>
4 tasks
yuval-k
approved these changes
Nov 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm; left a note to myself
nfuden
approved these changes
Nov 12, 2024
This was referenced Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates the gateway2 project to use EndpointSlice instead of Endpoints for creating upstream endpoints.
Fixes: https://github.com/solo-io/solo-projects/issues/6910
API changes
N/A
Code changes
The primary change is updating
proxy_syncer.TransformUpstreamsBuilder()
to transform an EndpointSlice into into aenvoy_config_endpoint_v3.LbEndpoint
instead of using an Endpoint.CI changes
Removes skipping k8s GW API conformance tests.
Docs changes
N/A (internal change)
Context
Required for passing k8s gw api conformance tests.
Testing steps
Updates existing tests.
Notes for reviewers
N/A
Checklist:
BOT NOTES:
resolves https://github.com/solo-io/solo-projects/issues/6910