Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

project/gateway2: Replaces Endpoints with EndpointSlice for Creating Upstream Endpoints #10265

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

danehans
Copy link
Contributor

@danehans danehans commented Nov 1, 2024

Description

Updates the gateway2 project to use EndpointSlice instead of Endpoints for creating upstream endpoints.

Fixes: https://github.com/solo-io/solo-projects/issues/6910

API changes

N/A

Code changes

The primary change is updating proxy_syncer.TransformUpstreamsBuilder() to transform an EndpointSlice into into a envoy_config_endpoint_v3.LbEndpoint instead of using an Endpoint.

CI changes

Removes skipping k8s GW API conformance tests.

Docs changes

N/A (internal change)

Context

Required for passing k8s gw api conformance tests.

Testing steps

Updates existing tests.

Notes for reviewers

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
    BOT NOTES:
    resolves https://github.com/solo-io/solo-projects/issues/6910

@solo-changelog-bot
Copy link

Issues linked to changelog:
https://github.com/solo-io/solo-projects/issues/6910

@danehans danehans marked this pull request as draft November 2, 2024 00:01
@danehans
Copy link
Contributor Author

danehans commented Nov 2, 2024

Converted to draft as I troubleshoot e2e failures.

@nfuden
Copy link
Contributor

nfuden commented Nov 3, 2024

Likely there are some lookups that currently hard code to endpoints which may be causing the breaks

@danehans danehans marked this pull request as ready for review November 5, 2024 00:41
Copy link
Member

@yuval-k yuval-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; left a note to myself

projects/gateway2/krtcollections/endpoints.go Show resolved Hide resolved
@nfuden nfuden added the Area: API activities related to API label Nov 12, 2024
@soloio-bulldozer soloio-bulldozer bot merged commit a93178d into solo-io:main Nov 12, 2024
18 checks passed
@danehans danehans deleted the issue_6910 branch November 12, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: API activities related to API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants