-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Opentelemetry span name (#10123) (master up-port) #10297
Conversation
Co-authored-by: changelog-bot <changelog-bot> Co-authored-by: Rachael Graham <[email protected]>
Issues linked to changelog: |
Visit the preview URL for this PR (updated for commit 30a4fb9): https://gloo-edge--pr10297-opentelemetry-span-n-2gqzpjcx.web.app (expires Mon, 18 Nov 2024 20:39:01 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
…loo into opentelemetry-span-name-master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like there are some unintentional codegen changes (proto versions). Fixing this should resolve the static code analysis job.
It looks like 2 e2e test suites failed. Can you investigate, and if we need to open flake issues or record a failure on an existing one, do that?
I see that build-bot did not start on this PR. Can you investigate that?
…loo into opentelemetry-span-name-master
Fixed by re-running
Almost definitely flakes. Will update the relevant issues and/or create them.
I'm going to guess that this is a one-off thing. Do you think we're in the clear on this, or if not have any suggestions on how to investigate this further? |
Description
up-port of #10123 to master
API changes
See linked pull request
Code changes
See linked pull request
Docs changes
See linked pull request
Context
Interesting decisions
Testing steps
Notes for reviewers
Checklist:
BOT NOTES:
resolves #9848