Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opentelemetry span name (#10123) (master up-port) #10297

Merged
merged 17 commits into from
Nov 11, 2024

Conversation

ashishb-solo
Copy link
Contributor

@ashishb-solo ashishb-solo commented Nov 8, 2024

Description

up-port of #10123 to master

API changes

See linked pull request

Code changes

See linked pull request

Docs changes

See linked pull request

Context

Interesting decisions

Testing steps

Notes for reviewers

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

BOT NOTES:
resolves #9848

Co-authored-by: changelog-bot <changelog-bot>
Co-authored-by: Rachael Graham <[email protected]>
@ashishb-solo ashishb-solo requested a review from a team as a code owner November 8, 2024 16:16
@github-actions github-actions bot added keep pr updated signals bulldozer to keep pr up to date with base branch work in progress signals bulldozer to keep pr open (don't auto-merge) labels Nov 8, 2024
@solo-changelog-bot
Copy link

Issues linked to changelog:
#9848

Copy link

github-actions bot commented Nov 8, 2024

Visit the preview URL for this PR (updated for commit 30a4fb9):

https://gloo-edge--pr10297-opentelemetry-span-n-2gqzpjcx.web.app

(expires Mon, 18 Nov 2024 20:39:01 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 77c2b86e287749579b7ff9cadb81e099042ef677

Copy link
Contributor

@sam-heilbron sam-heilbron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there are some unintentional codegen changes (proto versions). Fixing this should resolve the static code analysis job.

It looks like 2 e2e test suites failed. Can you investigate, and if we need to open flake issues or record a failure on an existing one, do that?

I see that build-bot did not start on this PR. Can you investigate that?

@ashishb-solo
Copy link
Contributor Author

Looks like there are some unintentional codegen changes (proto versions). Fixing this should resolve the static code analysis job.

Fixed by re-running make install-go-tools

It looks like 2 e2e test suites failed. Can you investigate, and if we need to open flake issues or record a failure on an existing one, do that?

Almost definitely flakes. Will update the relevant issues and/or create them.

I see that build-bot did not start on this PR. Can you investigate that?

I'm going to guess that this is a one-off thing. Do you think we're in the clear on this, or if not have any suggestions on how to investigate this further?

@ashishb-solo ashishb-solo removed the work in progress signals bulldozer to keep pr open (don't auto-merge) label Nov 11, 2024
@soloio-bulldozer soloio-bulldozer bot merged commit 0ed35ac into main Nov 11, 2024
19 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the opentelemetry-span-name-master branch November 11, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep pr updated signals bulldozer to keep pr up to date with base branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Span Name changes for OTEL filter
3 participants