Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sets.gotmpl: Add comment for filter behaviour #460

Merged
merged 2 commits into from
Jun 21, 2023
Merged

sets.gotmpl: Add comment for filter behaviour #460

merged 2 commits into from
Jun 21, 2023

Conversation

saiskee
Copy link
Contributor

@saiskee saiskee commented Jun 21, 2023 •
edited
Loading

This adds a comment to our filter behavior when using List / UnsortedList on Sets.

e.g. If filter returns true, we exclude it from the returned list.

jehawley
jehawley previously approved these changes Jun 21, 2023
View reviewed changes
arianaw66
arianaw66 previously approved these changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@arianaw66 arianaw66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this behavior has been bothering me for ages; this will help, at least.

@jenshu
Copy link
Contributor

jenshu commented Jun 21, 2023

Thank you, this behavior has been bothering me for ages

me too! #170

@saiskee saiskee dismissed stale reviews from arianaw66 and jehawley via 27f0b36 June 21, 2023 20:02
@soloio-bulldozer soloio-bulldozer bot merged commit 1934c8e into master Jun 21, 2023
@soloio-bulldozer soloio-bulldozer bot deleted the sai/filter-comment branch June 21, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jehawley jehawley jehawley approved these changes

@jenshu jenshu jenshu approved these changes

@arianaw66 arianaw66 arianaw66 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saiskee @jenshu @jehawley @arianaw66