feat(config): add circular dependency detection to ContractKeySchema …#1029
Open
Eromosele0110 wants to merge 1 commit into
Open
feat(config): add circular dependency detection to ContractKeySchema …#1029Eromosele0110 wants to merge 1 commit into
Eromosele0110 wants to merge 1 commit into
Conversation
…validation
Implement DFS with 3-color marking to detect circular references between
template field placeholders. A template may reference another schema field
via {field_name} placeholders (excluding {id}). Cycles are reported with
the full dependency path in the validation error.
Adds unit tests for:
- Two-node cycle detection (market ↔ platform_stats)
- Three-node cycle detection (market → user_bets → oracle_result → market)
- Acyclic default configuration validation
|
@Eromosele0110 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…validation
Implement DFS with 3-color marking to detect circular references between template field placeholders. A template may reference another schema field via {field_name} placeholders (excluding {id}). Cycles are reported with the full dependency path in the validation error.
Adds unit tests for:
Description
Type of Change
Testing Done
Checklist
Related Issues
Closes #939