Documented somewhat large amounts of code, largely based off the S&K disassembly #48
Conversation
GabrielRavier
changed the title
|
Btw, I'll also try to salvage the labeling changes I didn't take from #25 (mostly to be conservative and make sure this PR can be as simple as possible) into another PR based off this one later - this PR should be fine as is afaik, though |
|
I'm not sure I agree with the existence of the "doNothingForAWhileIfPALSystem" and "waitUntilHBlank" macros; they only appear 3 and 2 times, respectively, and the repetition of their underlying code seems to be the result of copy-pasting. |
|
Hmmm, makes sense - I've actually had this half-finished on my hard drive for a year or so and I don't even really remember why I made the macros in the first place, and if I forgot the rationale, it's likely just that I came up with it at 4AM or something without any compelling reason in retrospect. Will force-push with the macros taken out ASAP, do tell me if there's anything else bad in the PR. |
GabrielRavier
force-pushed
the
feat/salvage-github-pr-25
branch
from
4dd29d8 to
df50686
Compare
Note: most of this is what I managed to salvage from the complete mess known as sonicretro#25
GabrielRavier
force-pushed
the
feat/salvage-github-pr-25
branch
from
df50686 to
62d553f
Compare
|
Pushed new version without the macros - @Brainulator9 are there any other outstanding issues ? |
This is basically an attempt at salvaging what can be saved from the very old broken PR at #25