Offer engine recovery when a model fails to load#40
Merged
Conversation
A failed or stalled model load left the toolbar with only a red status chip; nothing pointed at the engine dropdown as the way out, so users were stuck on a broken engine. Show an explicit "Pick another model" action next to the error chip that opens the engine picker, and title the picker accordingly in that state. Route every engine switch through one shared flow (useEngineSwitch): the toolbar selector and the Hindi demo shortcut now both initialize the sidecar model and settle loading/error status. Previously the demo flipped the store without init, leaving a stale "ready" chip and deferring the whole model download to the first synthesis.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A failed or stalled model load left the toolbar with only a red status chip and no obvious way to switch engines. This makes the error state recoverable: a "Pick another model" button appears next to the error chip and opens the engine picker.
What changed
useEngineSwitchhook: single engine-switch flow (interrupt in-flight load, init the model, settle ready/error status, guard against the user switching again mid-init).Test plan
tscclean,vite buildok;cargo test31 unit + 6 sidecar integration tests pass.