Fix streaming audio startup de-click#374
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add configurable startup de-click handling to
StreamingAudioPlayerwithout adding default playback latency for existing model integrations.The default remains conservative: no startup pre-roll and a short 5 ms first-chunk fade. Clients that need stronger protection for neural codec startup transients can opt into a short zero pre-roll and longer fade-in through
startupPrerollDurationandstartupFadeInDuration.The PR also exposes
underflowCountso streaming clients can distinguish actual mid-phrase playback starvation from normal silence after generation completes.Why
Some neural codec TTS streams can begin with a non-zero or low-frequency transient. Starting the audio engine directly on that first sample can produce an audible dull click/pop at phrase start. Making the stronger de-click behavior configurable lets affected clients fix that startup artifact without changing timing for other models that already start cleanly.
Regression Safety
startupPrerollDurationis0, so existing playback paths do not gain extra startup latency.startupFadeInDurationis0.005, matching the previous short first-chunk fade window.Validation
swift test --filter StreamingAudioPlayerTests