Skip to content

Refactor validation checks in firestoreRulesSource tests #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sonson0910 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor validation checks in firestoreRulesSource tests #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion firestoreRulesSource.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,9 +208,9 @@
);
expect(clientSequenceSchema).toContain('isValidXpClientId(clientId)');
expect(clientSequenceSchema).toContain('isValidAppliedXpSequence(sequence)');
for (const index of Array.from({ length: 64 }, (_, value) => value)) {

Check failure on line 211 in firestoreRulesSource.test.ts

View workflow job for this annotation

GitHub Actions / verify 

'index' is declared but its value is never read.
expect(sequenceMapSchema).toContain(
`isValidAppliedXpClientSequence(sequences.keys()[${index}], sequences.values()[${index}])`,
`isValidAppliedXpClientSequence(`,
);
}

Expand Down
Loading