Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charmed_mysql] Add Charmed MySQL support #3970

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

vlad-apostol
Copy link
Contributor

@vlad-apostol vlad-apostol commented Mar 17, 2025

This plugin is intended to add support for Charmed MySQL deployments.
An example of the output for the report can be found here: Charmed MySQL example report

Please note: this PR requires PR #3968 to be merged before this is functional.

Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines

  • Is the commit message split over multiple lines and hard-wrapped at 72 characters?
  • Is the subject and message clear and concise?
  • Does the subject start with [plugin_name] if submitting a plugin patch or a [section_name] if part of the core sosreport code?
  • Does the commit contain a Signed-off-by: First Lastname [email protected]?
  • Are any related Issues or existing PRs properly referenced via a Closes (Issue) or Resolved (PR) line?
  • Are all passwords or private data gathered by this PR obfuscated?

@vlad-apostol vlad-apostol marked this pull request as draft March 17, 2025 18:23
@vlad-apostol vlad-apostol force-pushed the feature/charmed-mysql branch from b52bad4 to 2e9be3a Compare March 17, 2025 18:25
Copy link

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/sosreport-sos-3970
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@vlad-apostol vlad-apostol marked this pull request as ready for review March 17, 2025 18:31
Copy link
Member

@arif-ali arif-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you squash your commits, so that it's one commit please

@vlad-apostol vlad-apostol force-pushed the feature/charmed-mysql branch from 3fc5880 to e6602e2 Compare March 18, 2025 08:35
@vlad-apostol
Copy link
Contributor Author

Commits have been squashed

@vlad-apostol vlad-apostol requested a review from arif-ali March 18, 2025 08:36
@vlad-apostol vlad-apostol force-pushed the feature/charmed-mysql branch from c633a05 to 76d4590 Compare March 18, 2025 08:49
Copy link
Member

@arif-ali arif-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one final nit from me

Signed-off-by: Vlad Apostol <[email protected]>
@vlad-apostol vlad-apostol force-pushed the feature/charmed-mysql branch from 5cc3709 to 6a25f89 Compare March 18, 2025 12:20
@arif-ali arif-ali added Kind/Ubuntu Ubuntu related item Reviewed/Needs 2nd Ack Require a 2nd ack from a maintainer Status/Needs Review This issue still needs a review from project members labels Mar 18, 2025
Copy link
Member

@TurboTurtle TurboTurtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@TurboTurtle TurboTurtle added Reviewed/Ready for Merge Has been reviewed, ready for merge and removed Reviewed/Needs 2nd Ack Require a 2nd ack from a maintainer Status/Needs Review This issue still needs a review from project members labels Mar 18, 2025
@TurboTurtle TurboTurtle merged commit 75617bd into sosreport:main Mar 18, 2025
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kind/Ubuntu Ubuntu related item Reviewed/Ready for Merge Has been reviewed, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants