replace all usages of "List.of" with more readable "ImmutableList.of/copyOf" #515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…copyOf" to directly show the immutability. This might optimise internal operations, e.g., avoid copies from List to other Lists, if all are ImmutableLists.
kfriedberger
referenced
this pull request
Sep 3, 2025
…directly show the immutability. This might cause one additional copy of the array-content in some cases, however, we iterate over the content again in the next step, so this is just a very small overhead, and it brings the benefit of immutability.
Contributor
|
Good idea! Question: do we also want to switch to |
Member
Author
|
For the internal method signature, the benefit is quite small. Keeping signatures with |
Member
|
This PR has the same problem as I mentioned in d344e3a#commitcomment-165053827: It adds additional unnecessary copies by replacing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… to directly show the immutability.
This might optimise internal operations, e.g.,
avoid copies from List to other Lists, if all are ImmutableLists.