-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fit_aimpoint notebook for 2025-03 #30
Conversation
Question on the notebook - I'm a little confused about why we have a drift model (the drift model code / the class definition) in the notebook and one in chandra_aca - should they share the same model (code)? If the calibration version in the notebook needs to be separate, some comment on that would be helpful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
I added this to the
|
Description
This adds a new analysis notebook
fit_aimpoint_drift-2025-03.ipynb
which updates the aimpoint drift model by adding two jumps, one in 2023:046 (Safe Mode) and a second on 2024:001 (ad hoc).Unrelated fixes
Modernized the ruff config and made some benign changes.
Also remove
pyrightconfig.json
, which is only causing problems.Related PR's
Interface impacts
Testing
Unit tests
Functional tests
The notebook includes functional testing. See also: sot/chandra_aca#189.