Robust handling of missing ACE data in timeline #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of dropping bad ACE data at the point of reading in values, leave the bad values there (as indicated by a negative value) and do downstream handling of bad values. Indicate bad or N/A values with bold red text in the state table. If there is no average P3 from MTA then use 0.0 for fluence but show fluence as red.
taldcroft
added a commit
that referenced
this pull request
Apr 22, 2013
Robust handling of missing ACE data in timeline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ACE data has not been flowing for at least 4 days since Dec. 22, 2012. This causes program failure in make_timeline.py as noted in issue #10 as well as potential operational confusion. This PR improves the handling of missing ACE data and adds infrastructure to test various missing data scenarios.