Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace uses of pformat_all with pformat #266

Merged
merged 1 commit into from
Jan 6, 2025
Merged

replace uses of pformat_all with pformat #266

merged 1 commit into from
Jan 6, 2025

Conversation

javierggt
Copy link
Contributor

@javierggt javierggt commented Jan 4, 2025

Description

This is a change intended for skare3 > 2025.0, where we will use astropy 7.0. It replaces uses of Table.pformat_all() wih Table.pformat(). This silences a warning.

Interface impacts

Testing

Unit tests

  • Mac
(ska3-flight-2025.0rc5) ~/SAO/git/cheta pformat $ pytest cheta
============================================================= test session starts =============================================================
platform darwin -- Python 3.12.8, pytest-8.3.4, pluggy-1.5.0
rootdir: /Users/javierg/SAO/git
configfile: pytest.ini
plugins: anyio-4.7.0, timeout-2.3.1
collected 174 items                                                                                                                           

cheta/tests/test_comps.py ............................................................                                                  [ 34%]
cheta/tests/test_data_source.py .........                                                                                               [ 39%]
cheta/tests/test_fetch.py ................................                                                                              [ 58%]
cheta/tests/test_intervals.py .........................                                                                                 [ 72%]
cheta/tests/test_orbit.py .                                                                                                             [ 72%]
cheta/tests/test_remote_access.py ......                                                                                                [ 76%]
cheta/tests/test_sync.py ........                                                                                                       [ 81%]
cheta/tests/test_units.py ...........                                                                                                   [ 87%]
cheta/tests/test_units_reversed.py ...........                                                                                          [ 93%]
cheta/tests/test_utils.py ...........                                                                                                   [100%]

============================================================== warnings summary ===============================================================
cheta/cheta/tests/test_comps.py::test_cmd_states
  /Users/javierg/miniforge3/envs/ska3-flight-2025.0rc5/lib/python3.12/site-packages/setuptools_scm/git.py:312: UserWarning: git archive did not support describe output
    warnings.warn("git archive did not support describe output")

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
================================================== 174 passed, 1 warning in 93.40s (0:01:33) ==================================================

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

No functional testing.

@javierggt javierggt merged commit 7876696 into master Jan 6, 2025
2 checks passed
@javierggt javierggt deleted the pformat branch January 6, 2025 18:13
This was referenced Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants