Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace uses of pformat_all with pformat #404

Merged
merged 1 commit into from
Jan 6, 2025
Merged

replace uses of pformat_all with pformat #404

merged 1 commit into from
Jan 6, 2025

Conversation

javierggt
Copy link
Contributor

Description

This is a change intended for skare3 > 2025.0, where we will use astropy 7.0. It replaces uses of Table.pformat_all() wih Table.pformat(). This silences a warning.

Interface impacts

Testing

Unit tests

  • Mac
(ska3-flight-2025.0rc5) ~/SAO/git/proseco pformat $ pytest proseco 
============================================================= test session starts =============================================================
platform darwin -- Python 3.12.8, pytest-8.3.4, pluggy-1.5.0
rootdir: /Users/javierg/SAO/git
configfile: pytest.ini
plugins: anyio-4.7.0, timeout-2.3.1
collected 168 items                                                                                                                           

proseco/tests/test_acq.py .....................................                                                                         [ 22%]
proseco/tests/test_catalog.py ..........................................                                                                [ 47%]
proseco/tests/test_core.py ...........................                                                                                  [ 63%]
proseco/tests/test_diff.py ......                                                                                                       [ 66%]
proseco/tests/test_fid.py ...............                                                                                               [ 75%]
proseco/tests/test_guide.py .....................................                                                                       [ 97%]
proseco/tests/test_mon_full_cat.py ....                                                                                                 [100%]

============================================================== warnings summary ===============================================================
proseco/proseco/tests/test_catalog.py::test_get_aca_catalog_49531
proseco/proseco/tests/test_catalog.py::test_get_aca_catalog_49531
  /Users/javierg/miniforge3/envs/ska3-flight-2025.0rc5/lib/python3.12/site-packages/bs4/builder/_lxml.py:124: DeprecationWarning: The 'strip_cdata' option of HTMLParser() has never done anything and will eventually be removed.
    parser = parser(

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
====================================================== 168 passed, 2 warnings in 27.32s =======================================================
(ska3-flight-2025.0rc5) ~/SAO/git/proseco pformat $ git rev-parse --short HEAD 
54d4c19

Independent check of unit tests by [REVIEWER NAME]

  • [PLATFORM]:

Functional tests

No functional testing.

@javierggt javierggt merged commit f2d94a8 into master Jan 6, 2025
1 of 2 checks passed
@javierggt javierggt deleted the pformat branch January 6, 2025 18:13
This was referenced Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants