[Chess] Accelerate chess_utils.py import (jnp => np)
#1170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for a PR! I'll check it in a few days. |
|
Did the same modification to gardner_chess. The time gain is less impressive, but it still goes from 3-4s to <1s |
Akulen
commented
Mar 4, 2024
| # usage: CAN_MOVE[piece, from_x, from_y] | ||
| # CAN_MOVE[0, :, :] are all -1 | ||
| # Note that the board is not symmetric about the center (different from shogi) | ||
| # You can imagine that the viewpoint is always from the white side. | ||
| # Except PAWN, the moves are symmetric about the center. | ||
| # We define PAWN as a piece that can move up, down, and diagonally, and filter it according to the turn. | ||
| # We define PAWN as a piece that can move up and diagonally. |
There was a problem hiding this comment.
I'm not sure why, but it seems that for gardner chess, this comment was previously untrue, as the following condition (line 56) is
if r1 - r0 == 1 and np.abs(c1 - c0) <= 1:instead of
if np.abs(r1 - r0) == 1 and np.abs(c1 - c0) <= 1:
There was a problem hiding this comment.
This will be investigated in #1174
Thank you for your comment!
|
Hi! I'm so sorry for late response 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing
_src/chess_utils.pycurrently takes between 10 and 15 seconds.It is mainly due to the fact that all pre-computations are made on
jax.numpyarray, which are really slow.This PR reduces the import time to ~1s, by using
numpyarray instead, and converting them tojax.numpyarray at the end.